Page MenuHomePhabricator

[web] Move padding from `modal_body` to `tab_body` in `ThreadSettingsModal`
ClosedPublic

Authored by atul on May 5 2022, 7:08 AM.
Tags
None
Referenced Files
F3377017: D3930.id12282.diff
Wed, Nov 27, 3:30 AM
Unknown Object (File)
Sat, Nov 23, 12:08 PM
Unknown Object (File)
Sat, Nov 23, 11:28 AM
Unknown Object (File)
Sat, Nov 23, 9:32 AM
Unknown Object (File)
Sun, Nov 17, 6:28 AM
Unknown Object (File)
Tue, Nov 12, 3:42 AM
Unknown Object (File)
Mon, Nov 11, 7:15 PM
Unknown Object (File)
Mon, Nov 11, 3:21 PM

Details

Summary

We want each of the ThreadSettingsBlahTab components to have some padding so their contents aren't right against the edge of the surrounding Modal. However, we do want the Tabs to extend all the way to the edges and be closer to the Modal header.

We can't put these divs inside <Tabs.Container> because it expects its children to be typed a certain way. As a result we have to copy/paste the <div className={css.tab_body}> tag for every tab. We could move this padding to the children Tab components themselves, but setting the padding in ThreadSettingsModal seems like the right layer of abstraction to me.


Depends on D3929

Test Plan

Before:

Screen Shot 2022-05-05 at 10.00.34 AM.png (1×712 px, 74 KB)

After:

Screen Shot 2022-05-05 at 10.00.46 AM.png (1×712 px, 75 KB)

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul edited the summary of this revision. (Show Details)

reposition tab_body in stylesheet

atul published this revision for review.May 5 2022, 7:11 AM
This revision is now accepted and ready to land.May 5 2022, 8:57 AM