Paths

Table of Contentst

[web] Remove no longer relevant styles from `thread-settings-general-tab.css`
ClosedPublic
Actions

Authored by atul on May 5 2022, 7:52 AM.

Details

Reviewers

ashoat
tomek

Commits

rCOMMc4a4b5339381: [web] Remove no longer relevant styles from `thread-settings-general-tab.css`

Summary

There were some arbitrary margin values that were set as part of the old design. Removing the selectors/styles from the stylesheet and corresponding component to clean them up before working on ThreadSettingsGeneralTab layout/styling

Depends on D3930

Test Plan

ThreadSettingsGeneralTab component continues to look fine:

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.May 5 2022, 7:52 AM

Herald added subscribers: • abosh, • karol, • adrian. · View Herald TranscriptMay 5 2022, 7:52 AM

atul edited the test plan for this revision. (Show Details)May 5 2022, 7:52 AM

Harbormaster completed remote builds in B8819: Diff 12287.May 5 2022, 7:56 AM

atul requested review of this revision.May 5 2022, 7:56 AM

atul edited the summary of this revision. (Show Details)May 5 2022, 8:11 AM

atul added a parent revision: D3930: [web] Move padding from `modal_body` to `tab_body` in `ThreadSettingsModal`.

atul added a child revision: D3933: [web] Tweak layout of `ThreadSettingsGeneralTab`.

ashoat accepted this revision.May 5 2022, 8:57 AM

This revision is now accepted and ready to land.May 5 2022, 8:57 AM

Closed by commit rCOMMc4a4b5339381: [web] Remove no longer relevant styles from `thread-settings-general-tab.css` (authored by atul). · Explain WhyMay 5 2022, 9:20 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMc4a4b5339381: [web] Remove no longer relevant styles from `thread-settings-general-tab.css`.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

thread-settings-general-tab.css

12 lines

thread-settings-general-tab.react.js

6 lines

Diff 12287

View Options

web/modals/threads/thread-settings-general-tab.css