Page MenuHomePhabricator
Differential D4023

[web] [refactor] [ENG-536] use input component
ClosedPublic
Actions

Authored by • benschac on May 12 2022, 3:24 PM.
Tags
None
Referenced Files
F3867011: D4023.diff
Wed, Jan 22, 11:57 AM
Unknown Object (File)
Wed, Jan 15, 3:42 PM
Unknown Object (File)
Sun, Jan 12, 4:54 PM
Unknown Object (File)
Sun, Jan 12, 4:31 PM
Unknown Object (File)
Sun, Jan 5, 3:00 PM
Unknown Object (File)
Sun, Jan 5, 3:00 PM
Unknown Object (File)
Sun, Jan 5, 3:00 PM
Unknown Object (File)
Sun, Jan 5, 2:59 PM
View All Files
Subscribers
• abosh
• adrian
ashoat

Details

Reviewers
atul
tomek
• jacek
Commits
rCOMM141a61f432a4: [web] [refactor] [ENG-536] use input component
Summary

use our input component moving forward

Test Plan

type text into input field

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• benschac created this revision.May 12 2022, 3:24 PM
Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptMay 12 2022, 3:24 PM
• benschac added a parent revision: D4022: [native, lib, web] move search sidebar functionality to lib hooks.May 12 2022, 3:24 PM
Harbormaster completed remote builds in B9055: Diff 12599.May 12 2022, 3:30 PM
• benschac requested review of this revision.May 12 2022, 3:30 PM
tomek accepted this revision.May 13 2022, 4:10 AM

Could you share a screenshot?

web/modals/chat/sidebar-list-modal.react.js
122 ↗(On Diff #12599)

Isn't the input enabled by default?

This revision is now accepted and ready to land.May 13 2022, 4:10 AM
• benschac mentioned this in D4035: [web] [fix] [ENG-536] disable input prop by default.May 13 2022, 7:28 AM
• benschac added a parent revision: D4035: [web] [fix] [ENG-536] disable input prop by default.May 13 2022, 7:29 AM
• benschac removed a parent revision: D4022: [native, lib, web] move search sidebar functionality to lib hooks.
• benschac updated this revision to Diff 12658.May 13 2022, 7:32 AM

remove disabled prop

• benschac added inline comments.May 13 2022, 7:34 AM
web/modals/chat/sidebar-list-modal.react.js
122 ↗(On Diff #12599)

No, but it really should be, added a diff here: https://phabricator.ashoat.com/D4035

Harbormaster completed remote builds in B9098: Diff 12658.May 13 2022, 7:38 AM
tomek accepted this revision.May 13 2022, 7:40 AM
tomek added inline comments.
web/modals/chat/sidebar-list-modal.react.js
122 ↗(On Diff #12599)

Thanks!

Closed by commit rCOMM141a61f432a4: [web] [refactor] [ENG-536] use input component (authored by • benschac). · Explain WhyMay 13 2022, 7:52 AM
This revision was automatically updated to reflect the committed changes.
• benschac mentioned this in rCOMMe6c083209aad: [web] [fix] [ENG-536] disable input prop by default.
• benschac added a commit: rCOMM141a61f432a4: [web] [refactor] [ENG-536] use input component.

Revision Contents
Changeset List

PathSize
web/
modals/
chat/
3 lines

Diff 12661

View Options

web/modals/chat/sidebar-list-modal.react.js

Loading...