Page MenuHomePhabricator
Differential D4056

[native, web, lib] [refactor] [ENG-536] move search index to hook
ClosedPublic
Actions

Authored by • benschac on May 16 2022, 8:05 AM.
Tags
None
Referenced Files
F6238075: D4056.id12815.diff
Thu, Apr 24, 5:39 PM
Unknown Object (File)
Thu, Apr 24, 4:01 PM
Unknown Object (File)
Wed, Apr 23, 6:02 AM
Unknown Object (File)
Fri, Apr 18, 1:59 PM
Unknown Object (File)
Fri, Apr 18, 1:20 AM
Unknown Object (File)
Thu, Apr 17, 2:12 PM
Unknown Object (File)
Thu, Apr 17, 10:54 AM
Unknown Object (File)
Thu, Apr 17, 8:01 AM
View All Files
Subscribers
• abosh
• adrian
ashoat

Details

Reviewers
atul
tomek
• jacek
Commits
rCOMM6205a4947c09: [native, web, lib] [refactor] [ENG-536] move search index to hook
Summary

moves the search index code that's used in both native and web into lib/hooks

Test Plan

test sidebar search functionality in both native/ and web they should both work as expected.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• benschac created this revision.May 16 2022, 8:05 AM
Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptMay 16 2022, 8:05 AM
• benschac added a parent revision: D4022: [native, lib, web] move search sidebar functionality to lib hooks.May 16 2022, 8:06 AM
• benschac added a child revision: D4057: [lib, native, web] move onChangeSearch to hook.
Harbormaster completed remote builds in B9165: Diff 12744.May 16 2022, 8:11 AM
• benschac requested review of this revision.May 16 2022, 8:11 AM
• benschac updated this revision to Diff 12772.May 16 2022, 2:21 PM

rebase

Harbormaster completed remote builds in B9181: Diff 12772.May 16 2022, 2:26 PM
• benschac updated this revision to Diff 12815.May 17 2022, 7:57 AM

rebase

Harbormaster failed remote builds in B9222: Diff 12815!May 17 2022, 8:01 AM
• benschac updated this revision to Diff 12822.May 17 2022, 8:02 AM

rebase

Harbormaster failed remote builds in B9229: Diff 12822!May 17 2022, 8:02 AM
Harbormaster completed remote builds in B9222: Diff 12815.May 17 2022, 8:34 AM
Harbormaster completed remote builds in B9229: Diff 12822.May 17 2022, 8:47 AM
tomek accepted this revision.May 18 2022, 3:26 AM
This revision is now accepted and ready to land.May 18 2022, 3:26 AM
Closed by commit rCOMM6205a4947c09: [native, web, lib] [refactor] [ENG-536] move search index to hook (authored by • benschac). · Explain WhyMay 19 2022, 12:40 PM
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMM6205a4947c09: [native, web, lib] [refactor] [ENG-536] move search index to hook.

Revision Contents
Changeset List

PathSize
lib/
hooks/
36 lines
native/
chat/
39 lines
web/
modals/
chat/
40 lines

Diff 12815

View Options

lib/hooks/search-sidebars.js

  • This file was moved to lib/hooks/search-threads.js.
View Options

native/chat/sidebar-list-modal.react.js

  • This file was moved to lib/hooks/search-threads.js.
View Options

web/modals/chat/sidebar-list-modal.react.js

  • This file was moved to lib/hooks/search-threads.js.