Page MenuHomePhabricator
Differential D4058

[web, lib] [refactor] [ENG-536] move clear query to lib/hooks
ClosedPublic
Actions

Authored by • benschac on May 16 2022, 8:36 AM.
Tags
None
Referenced Files
F6303139: D4058.diff
Sat, Apr 26, 6:23 AM
Unknown Object (File)
Thu, Apr 17, 2:51 PM
Unknown Object (File)
Thu, Apr 17, 12:00 PM
Unknown Object (File)
Thu, Apr 17, 11:13 AM
Unknown Object (File)
Thu, Apr 17, 10:57 AM
Unknown Object (File)
Thu, Apr 17, 10:42 AM
Unknown Object (File)
Thu, Apr 17, 4:31 AM
Unknown Object (File)
Thu, Apr 17, 2:44 AM
View All Files
Subscribers
• abosh
• adrian
ashoat

Details

Reviewers
atul
tomek
• jacek
Commits
rCOMM50a152a78c58: [web, lib] [refactor] [ENG-536] move clear query to lib/hooks
Summary

move clear query method to lib hooks.

Test Plan

clear query functionality should work as it did before on web. This clear query wasn't implemented on native.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• benschac created this revision.May 16 2022, 8:36 AM
Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptMay 16 2022, 8:36 AM
• benschac added a parent revision: D4057: [lib, native, web] move onChangeSearch to hook.May 16 2022, 8:36 AM
Harbormaster completed remote builds in B9168: Diff 12747.May 16 2022, 8:41 AM
• benschac requested review of this revision.May 16 2022, 8:41 AM
• benschac updated this revision to Diff 12774.May 16 2022, 2:21 PM

rebase

Harbormaster completed remote builds in B9183: Diff 12774.May 16 2022, 2:34 PM
• benschac added a child revision: D4060: [native, lib, web] [refactor] move text out of state.May 16 2022, 2:38 PM
• benschac updated this revision to Diff 12817.May 17 2022, 7:57 AM

rebase

• benschac added inline comments.May 17 2022, 7:59 AM
lib/hooks/search-sidebars.js
26

this one is missing a +

• benschac updated this revision to Diff 12820.May 17 2022, 8:00 AM

add plus

Harbormaster failed remote builds in B9227: Diff 12820!May 17 2022, 8:01 AM
Harbormaster failed remote builds in B9224: Diff 12817!
• benschac updated this revision to Diff 12825.May 17 2022, 8:02 AM

rebase

Harbormaster completed remote builds in B9232: Diff 12825.May 17 2022, 8:35 AM
Harbormaster completed remote builds in B9224: Diff 12817.
Harbormaster completed remote builds in B9227: Diff 12820.May 17 2022, 8:49 AM
tomek accepted this revision.May 18 2022, 3:35 AM
This revision is now accepted and ready to land.May 18 2022, 3:35 AM
• benschac updated this revision to Diff 13090.May 24 2022, 10:23 AM

rebase

Harbormaster completed remote builds in B9452: Diff 13090.May 24 2022, 10:36 AM
• benschac updated this revision to Diff 13176.May 27 2022, 11:37 AM

fix merge conflicts

Harbormaster completed remote builds in B9513: Diff 13176.May 27 2022, 11:42 AM
• benschac updated this revision to Diff 13177.May 27 2022, 11:52 AM

rename variable

This revision was landed with ongoing or failed builds.May 27 2022, 11:56 AM
Closed by commit rCOMM50a152a78c58: [web, lib] [refactor] [ENG-536] move clear query to lib/hooks (authored by • benschac). · Explain Why
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMM50a152a78c58: [web, lib] [refactor] [ENG-536] move clear query to lib/hooks.
Harbormaster completed remote builds in B9514: Diff 13177.May 27 2022, 11:59 AM

Revision Contents
Changeset List

PathSize
lib/
hooks/
12 lines
web/
modals/
chat/
10 lines

Diff 12817

View Options

lib/hooks/search-sidebars.js

// @flow // @flow
import genesis from 'lib/facts/genesis.js';
import { import {
permissionLookup, permissionLookup,
makePermissionsBlob, makePermissionsBlob,
getRoleForPermissions, getRoleForPermissions,
} from 'lib/permissions/thread-permissions.js'; } from 'lib/permissions/thread-permissions.js';
import { relationshipBlockedInEitherDirection } from 'lib/shared/relationship-utils.js'; import { relationshipBlockedInEitherDirection } from 'lib/shared/relationship-utils.js';
import { import {
threadFrozenDueToBlock, threadFrozenDueToBlock,
▲ Show 20 Lines • Show All 290 Lines • ▼ Show 20 Lines if (memberRelationshipHasBlock) {
ignoreMembers.add(memberID); ignoreMembers.add(memberID);
continue; continue;
} }
const permissionsFromParent = parentPermissions[memberID]; const permissionsFromParent = parentPermissions[memberID];
if (memberOfContainingThread.get(memberID) === 'non-member') { if (memberOfContainingThread.get(memberID) === 'non-member') {
ignoreMembers.add(memberID); ignoreMembers.add(memberID);
continue; continue;
} }
const isParentThreadGenesis = params.parentThreadID === genesis.id;
if ( if (
memberOfContainingThread.get(memberID) === 'no-containing-thread' && (memberOfContainingThread.get(memberID) === 'no-containing-thread' ||
isParentThreadGenesis) &&
relationshipStatus !== userRelationshipStatus.FRIEND && relationshipStatus !== userRelationshipStatus.FRIEND &&
requireRelationship requireRelationship
) { ) {
ignoreMembers.add(memberID); ignoreMembers.add(memberID);
continue; continue;
} }
const permissions = makePermissionsBlob( const permissions = makePermissionsBlob(
params.defaultRolePermissions, params.defaultRolePermissions,
▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines
View Options

web/modals/chat/sidebar-list-modal.react.js

// @flow // @flow
import genesis from 'lib/facts/genesis.js';
import { import {
permissionLookup, permissionLookup,
makePermissionsBlob, makePermissionsBlob,
getRoleForPermissions, getRoleForPermissions,
} from 'lib/permissions/thread-permissions.js'; } from 'lib/permissions/thread-permissions.js';
import { relationshipBlockedInEitherDirection } from 'lib/shared/relationship-utils.js'; import { relationshipBlockedInEitherDirection } from 'lib/shared/relationship-utils.js';
import { import {
threadFrozenDueToBlock, threadFrozenDueToBlock,
▲ Show 20 Lines • Show All 290 Lines • ▼ Show 20 Lines if (memberRelationshipHasBlock) {
ignoreMembers.add(memberID); ignoreMembers.add(memberID);
continue; continue;
} }
const permissionsFromParent = parentPermissions[memberID]; const permissionsFromParent = parentPermissions[memberID];
if (memberOfContainingThread.get(memberID) === 'non-member') { if (memberOfContainingThread.get(memberID) === 'non-member') {
ignoreMembers.add(memberID); ignoreMembers.add(memberID);
continue; continue;
} }
const isParentThreadGenesis = params.parentThreadID === genesis.id;
if ( if (
memberOfContainingThread.get(memberID) === 'no-containing-thread' && (memberOfContainingThread.get(memberID) === 'no-containing-thread' ||
isParentThreadGenesis) &&
relationshipStatus !== userRelationshipStatus.FRIEND && relationshipStatus !== userRelationshipStatus.FRIEND &&
requireRelationship requireRelationship
) { ) {
ignoreMembers.add(memberID); ignoreMembers.add(memberID);
continue; continue;
} }
const permissions = makePermissionsBlob( const permissions = makePermissionsBlob(
params.defaultRolePermissions, params.defaultRolePermissions,
▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines