Add search sidebar functionality to search modal
I still need to style the sidebar items and the modal when it doesn't have content which I'll update in a following diff.
web:
native:
Paths
| Differential D4061 Authored by tomek on May 16 2022, 2:31 PM.
Details
Summary Test Plan Go to sidebar in web/ and native. Test functionality. Both should work as they did before. Web UI should be updated
Diff Detail
Event TimelineHerald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptMay 16 2022, 2:31 PM2022-05-16 14:31:37 (UTC-7) • benschac edited the summary of this revision. (Show Details)May 16 2022, 2:33 PM2022-05-16 14:33:20 (UTC-7) • benschac added inline comments.
Harbormaster completed remote builds in B9185: Diff 12776.May 16 2022, 2:37 PM2022-05-16 14:37:35 (UTC-7) • benschac edited the summary of this revision. (Show Details)May 16 2022, 3:03 PM2022-05-16 15:03:36 (UTC-7) Harbormaster failed remote builds in B9226: Diff 12819!May 17 2022, 8:02 AM2022-05-17 08:02:35 (UTC-7) Harbormaster completed remote builds in B9234: Diff 12827.May 17 2022, 8:39 AM2022-05-17 08:39:46 (UTC-7) Comment Actions After this diff, something is wrong with the design of the hook. We have two ways of updating the search text: by calling the hook with different text and by calling onChangeSearchText. Could you spend some time searching for a design which is easier to reason about? If there's none, please try to explain why do we need to have these complicated state transitions. This revision now requires changes to proceed.May 19 2022, 1:25 AM2022-05-19 01:25:35 (UTC-7) Harbormaster completed remote builds in B9454: Diff 13092.May 24 2022, 10:49 AM2022-05-24 10:49:57 (UTC-7) tomek abandoned this revision. Comment ActionsThe task from the title https://linear.app/comm/issue/ENG-536/sidebar-list-modal-re-style - is marked as done. If we decide to do something more about that issue, it would be probably easier to do it from scratch instead of figuring out how to make this stack solve the problem.
Revision Contents
Diff 13092 lib/hooks/search-sidebars.js
web/modals/chat/sidebar-list-modal.react.js
|