Differential D4122

[web] [feat] [ENG-536] style sidebars modal
AbandonedPublic
Actions

Authored by • benschac on May 24 2022, 10:29 AM.

Tags

None

Referenced Files

	F4098592: D4122.id13095.diff
	Mon, Feb 17, 1:46 AM

	F4098577: D4122.id.diff
	Mon, Feb 17, 1:45 AM

	F4098566: D4122.diff
	Mon, Feb 17, 1:42 AM

	Unknown Object (File)
	Tue, Jan 28, 6:51 PM

	Unknown Object (File)
	Mon, Jan 27, 9:13 AM

	Unknown Object (File)
	Mon, Jan 27, 6:40 AM

	Unknown Object (File)
	Jan 17 2025, 11:13 AM

	Unknown Object (File)
	Jan 16 2025, 10:45 AM

Subscribers

Details

Reviewers

tomek
ashoat
atul

Summary

add basic styling to the sidebars modal

Test Plan

will add screen shots, there isn't design for this screen. I'll get feedback from @ashoat

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.May 24 2022, 10:29 AM

Herald added subscribers: • abosh, • adrian. · View Herald TranscriptMay 24 2022, 10:29 AM

• benschac added a parent revision: D4067: [web, lib, native] [refactor] [ENG-536] rename listData to sidebar.May 24 2022, 10:30 AM

Harbormaster completed remote builds in B9457: Diff 13095.May 24 2022, 11:13 AM

• benschac requested review of this revision.May 24 2022, 11:13 AM

Please attach screenshots before requesting review

web/chat/sidebar-modal-item.react.js
16	"Sidebar" is one word. @palys-swm gave you this feedback in D4066 and D4067, and it hasn't been addressed in either, so I'm a bit worried that you missed it. Requesting changes to make sure you grok this feedback and internalize it, so it doesn't have to be repeated again

This revision now requires changes to proceed.May 24 2022, 12:31 PM

@jacek I believe you handled this separately? It looks fine on prod.

atul abandoned this revision.Aug 15 2022, 10:37 AM

atul foisted this revision upon • benschac.

atul edited reviewers, added: atul; removed: • benschac.

Revision Contents
Changeset List

Path

Size

web/

chat/

sidebar-modal-item.css

33 lines

sidebar-modal-item.react.js

54 lines

modals/

chat/

sidebar-list-modal.react.js

7 lines

1 line

Diff 13095

web/chat/sidebar-modal-item.css

Loading...

web/chat/sidebar-modal-item.react.js

Loading...

web/modals/chat/sidebar-list-modal.react.js

Loading...

web/theme.css

Loading...