Page MenuHomePhabricator
Differential D4213

[keyserver] Create dc.sh script
ClosedPublic
Actions

Authored by ashoat on Jun 5 2022, 10:20 PM.
Tags
None
Referenced Files
F2190798: D4213.id13359.diff
Thu, Jul 4, 12:32 PM
F2190708: D4213.id13343.diff
Thu, Jul 4, 12:11 PM
F2181803: D4213.id13359.diff
Wed, Jul 3, 6:11 PM
Unknown Object (File)
Wed, Jul 3, 6:46 AM
Unknown Object (File)
Tue, Jul 2, 8:59 AM
Unknown Object (File)
Mon, Jul 1, 4:37 AM
Unknown Object (File)
Sun, Jun 30, 6:19 AM
Unknown Object (File)
Sat, Jun 29, 7:30 PM
View All Files
Subscribers
• abosh
• adrian

Details

Reviewers
tomek
atul
Commits
rCOMMfbad63973bd4: [keyserver] Create dc.sh script
Summary

We're going to want Docker hosts to run this script instead of docker compose and docker-compose commands. More details on why it's necessary in D4211 and ENG-1230.

Making this a bash script instead of a yarn script so that Docker hosts don't need to install yarn in order to run it.

Depends on D4212

Test Plan

I tested this in concert with D4211

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Jun 5 2022, 10:20 PM
Herald added subscribers: • abosh, • adrian. · View Herald TranscriptJun 5 2022, 10:20 PM
ashoat added a child revision: D4214: [keyserver] Avoid redownloading Node from nvm whenever any files change.Jun 5 2022, 10:22 PM
ashoat edited the summary of this revision. (Show Details)Jun 5 2022, 10:22 PM
ashoat added inline comments.Jun 5 2022, 10:25 PM
keyserver/bash/dc.sh
8

I got ${@:1} from https://stackoverflow.com/a/42832469/427010

Harbormaster completed remote builds in B9627: Diff 13343.Jun 5 2022, 10:33 PM
ashoat requested review of this revision.Jun 5 2022, 10:33 PM
tomek accepted this revision.Jun 6 2022, 2:30 AM
This revision is now accepted and ready to land.Jun 6 2022, 2:30 AM
Closed by commit rCOMMfbad63973bd4: [keyserver] Create dc.sh script (authored by ashoat). · Explain WhyJun 6 2022, 4:55 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMfbad63973bd4: [keyserver] Create dc.sh script.
• abosh mentioned this in D4367: [keyserver] Revise `dc.sh` passed parameters.Jun 27 2022, 12:09 PM
• abosh mentioned this in rCOMM74bbe7e0491d: [keyserver] Revise `dc.sh` passed parameters.Jun 30 2022, 9:01 AM

Revision Contents
Changeset List

PathSize
keyserver/
bash/
8 lines

Diff 13343

View Options

keyserver/bash/dc.sh

Loading...