Page MenuHomePhabricator

[services] Tunnelbroker - Add test for the RemoveMessageItemsOlderThenCheckpoint database method
AbandonedPublic

Authored by max on Jun 6 2022, 6:49 AM.
Tags
None
Referenced Files
F3157140: D4221.diff
Tue, Nov 5, 7:21 PM
Unknown Object (File)
Sat, Nov 2, 2:21 PM
Unknown Object (File)
Sat, Nov 2, 2:20 PM
Unknown Object (File)
Sat, Nov 2, 2:17 PM
Unknown Object (File)
Tue, Oct 29, 9:58 AM
Unknown Object (File)
Tue, Oct 29, 4:30 AM
Unknown Object (File)
Mon, Oct 14, 8:05 PM
Unknown Object (File)
Sep 27 2024, 12:23 AM

Details

Reviewers
karol
tomek
Summary

This diff introduces a test plan for the removeMessageItemsOlderThenDeviceCheckpoint() database method that was introduced in D4220.

The test flow is following:

  1. Insert new message item.
  2. Find the message item by the receiver deviceID.
  3. Check if found items are not zero.
  4. Call removeMessageItemsOlderThenDeviceCheckpoint with the deviceID and checkpoint time greater than that was during the first insert.
  5. Find the message item by the receiver deviceID.
  6. Check if the found items are equal to zero.

Linear task: ENG-1303

Test Plan

Run test-tunnelbroker-service-dev-mode, successfully passed RemoveMessageItemsOlderThenCheckpoint test.

Diff Detail

Repository
rCOMM Comm
Branch
test-for-remove-messages-by-checkpoint
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

max held this revision as a draft.
max edited the test plan for this revision. (Show Details)
max added reviewers: karol, tomek.

It might be a good idea to have a test that deletes only some messages and not all of them.

Also, summary should mention test not test plan.

This revision is now accepted and ready to land.Jun 7 2022, 2:59 AM

This diff is canceled due to the architecture changes in ENG-1158 (comment):
We've moved from time-based checkpointing to the messageID-based and removing by a batch in D4476 and ENG-1361. This diff is replaced by D4478.