Page MenuHomePhabricator
Differential D4292

[Nix] Update nix flake lock, fix arcanist
ClosedPublic
Actions

Authored by • jon on Jun 19 2022, 11:15 AM.
Tags
None
Referenced Files
F3339295: D4292.diff
Thu, Nov 21, 7:34 PM
Unknown Object (File)
Wed, Nov 20, 4:05 PM
Unknown Object (File)
Tue, Nov 12, 12:15 PM
Unknown Object (File)
Sun, Nov 10, 1:37 AM
Unknown Object (File)
Tue, Nov 5, 1:07 PM
Unknown Object (File)
Tue, Nov 5, 8:35 AM
Unknown Object (File)
Oct 16 2024, 4:05 PM
Unknown Object (File)
Oct 13 2024, 8:55 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek
varun

Details

Reviewers
varun
ashoat
Commits
rCOMM05854b131c4c: [Nix] Update nix flake lock, fix arcanist
Summary

Fixes arcanist, avoid using php8.1 as it's current unsupported

Depends on D4181

Test Plan

nix develop && arc diff

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Jun 19 2022, 11:15 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJun 19 2022, 11:15 AM
• jon added a child revision: D4293: [services] Bump libuv compatibility.Jun 19 2022, 11:17 AM
Harbormaster completed remote builds in B9802: Diff 13566.Jun 19 2022, 11:20 AM
• jon requested review of this revision.Jun 19 2022, 11:20 AM
• jon retitled this revision from Update nix flake lock to [Nix] Update nix flake lock.Jun 19 2022, 11:30 AM
• jon edited the summary of this revision. (Show Details)
• jon retitled this revision from [Nix] Update nix flake lock to [Nix] Update nix flake lock, fix arcanist.Jun 20 2022, 5:05 PM
varun accepted this revision.Jun 21 2022, 11:30 AM
This revision is now accepted and ready to land.Jun 21 2022, 11:30 AM
Herald added a reviewer: ashoat. · View Herald TranscriptJun 21 2022, 11:30 AM
This revision now requires review to proceed.Jun 21 2022, 11:30 AM
varun added inline comments.Jun 21 2022, 11:51 AM
nix/overlay.nix
25 ↗(On Diff #13566)

nit: PHP 8.1

25 ↗(On Diff #13566)

nvm, actually, i see it styled as php8.1 too

ashoat added inline comments.Jun 22 2022, 10:17 AM
nix/overlay.nix
25 ↗(On Diff #13566)

Please keep all lines to a maximum of 80 chars!! (Exceptions for quirky languages such as Objective-C and bash)

ashoat accepted this revision.Jun 22 2022, 10:17 AM
This revision is now accepted and ready to land.Jun 22 2022, 10:17 AM
• jon updated this revision to Diff 13697.Jun 22 2022, 7:53 PM
• jon marked 3 inline comments as done.

Line length

• jon added a comment.Jun 22 2022, 7:53 PM

Addressed comments :)

Harbormaster completed remote builds in B9905: Diff 13697.Jun 22 2022, 8:33 PM
Closed by commit rCOMM05854b131c4c: [Nix] Update nix flake lock, fix arcanist (authored by • jon). · Explain WhyJun 22 2022, 9:25 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM05854b131c4c: [Nix] Update nix flake lock, fix arcanist.

Revision Contents
Changeset List

PathSize
6 lines
nix/
6 lines

Diff 13697

View Options

flake.lock

Loading...
View Options

nix/overlay.nix

Loading...