Update modules build after changes to master
AbandonedPublic
Actions

Authored by • jon on Jul 5 2022, 11:56 AM.

Details

Reviewers

• max
• karol
atul
varun
ashoat

Summary

The structure of the NativeModules
directory has changed on master. Due to the
order in which the changes took place, these
changes can't be applied to D4296

Depends on D4302

Test Plan

cd native/cpp && mkdir build && cd build && cmake .. && make

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Jul 5 2022, 11:56 AM

Herald added subscribers: • abosh, atul, • adrian, tomek. · View Herald TranscriptJul 5 2022, 11:56 AM

• jon added a child revision: D4448: Update android build with cmake changes.Jul 5 2022, 11:59 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 5 2022, 12:01 PM

Harbormaster failed remote builds in B10301: Diff 14201!

Lint

• jon added reviewers: atul, varun.Jul 7 2022, 3:42 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 7 2022, 3:51 PM

Harbormaster failed remote builds in B10394: Diff 14304!

• jon requested review of this revision.Jul 7 2022, 6:35 PM

Resigning since I'm usually not a good person to set as a first-pass reviewer. Exceptions here

cd native/cpp && mkdir build && cd build && cmake .. && make

Running into

CMake Error at /opt/homebrew/lib/cmake/grpc/gRPCTargets.cmake:72 (set_target_properties):
  The link interface of target "gRPC::grpc" contains:

    OpenSSL::SSL

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Call Stack (most recent call first):
  /opt/homebrew/lib/cmake/grpc/gRPCConfig.cmake:25 (include)
  CommonCpp/grpc/CMakeLists.txt:6 (find_package)

Is the assumption that this should be run within a nix shell? Can we use FetchContent here to make this build more portable?

This revision now requires changes to proceed.Jul 15 2022, 11:05 AM

• jon removed a child revision: D4448: Update android build with cmake changes.Jul 18 2022, 7:01 PM

should be able to re-order this to not need this diff. Or if I do, it will look quite different

• jon abandoned this revision.Aug 12 2022, 4:18 PM