Implements dile and directory initialization for flat-file message storage.
Details
Details
Modify AppDelegate so that on app launch it prints the content of the directory TemporaryMessageStore was initialized with. Ensure that file ending with Unix timestamp is there.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/ios/Comm/TemporalMessageStorage/TemporalMessageStorage.mm | ||
|---|---|---|
| 22 ↗ | (On Diff #13926) | We can invert this condition to reduce indentation. We just need the line return self in two places, which I think is worth it |
| native/ios/Comm/TemporalMessageStorage/TemporalMessageStorage.mm | ||
|---|---|---|
| 22 ↗ | (On Diff #13926) | You are right. I will do the refactoring. |
| native/ios/Comm/TemporalMessageStorage/TemporalMessageStorage.mm | ||
|---|---|---|
| 7 ↗ | (On Diff #14068) | It is not yet used - it should be defined in a diff that uses it |
| 24 ↗ | (On Diff #14068) | Wondering if we should define @"group.app.comm" in a common place |
| 29–32 ↗ | (On Diff #14068) | Should we check if the operation was successful? |
| native/ios/Comm/TemporalMessageStorage/TemporalMessageStorage.mm | ||
|---|---|---|
| 29–32 ↗ | (On Diff #14068) | Current implementation will not attempt any write or read operation if this operation failed (so the directory does not exist). Bu we should check against its failure and log it, since if it happens one day we will need more details. |
| native/ios/Comm/TemporalMessageStorage/TemporalMessageStorage.mm | ||
|---|---|---|
| 24 ↗ | (On Diff #14068) | I think we definitely we need a common place for this constant and we already have a Linear Task for that: https://linear.app/comm/issue/ENG-585/create-common-place-for-constants. I would not block landing this stack on this task, but it is probably a high time someone was assigned this issue. |