Page MenuHomePhabricator
Differential D4391

Define interface for flat-file based message storage operations
ClosedPublic
Actions

Authored by marcin on Jun 29 2022, 2:38 AM.
Tags
None
Referenced Files
F3384095: D4391.id14481.diff
Thu, Nov 28, 7:21 PM
F3384038: D4391.id14165.diff
Thu, Nov 28, 7:07 PM
F3383654: D4391.diff
Thu, Nov 28, 5:11 PM
Unknown Object (File)
Mon, Nov 25, 3:43 AM
Unknown Object (File)
Mon, Nov 25, 3:17 AM
Unknown Object (File)
Mon, Nov 25, 3:15 AM
Unknown Object (File)
Mon, Nov 11, 7:50 PM
Unknown Object (File)
Mon, Nov 11, 7:40 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul

Details

Reviewers
tomek
varun
• karol
Commits
rCOMM8f4ffc3eb09f: Define interface for flat-file based message storage operations
Summary

This diff defines API in the form of Obj-C class that AppDelegate and NotificationService will use to write/retrieve messages temporarilt stored in a flat file.

Test Plan

No test plan. Future diffs that use this API in NotificationService and AppDelegate will provide appropriate test plan

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Jun 29 2022, 2:38 AM
Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptJun 29 2022, 2:38 AM
Harbormaster completed remote builds in B10071: Diff 13925.Jun 29 2022, 2:50 AM
marcin requested review of this revision.Jun 29 2022, 2:50 AM
marcin added a parent revision: D4385: Implement elementary file operations with encryption-decryption layer.Jun 29 2022, 2:53 AM
marcin added a child revision: D4392: Implement flat-file based message storage initialization.
marcin updated this revision to Diff 14067.Jul 1 2022, 2:03 AM

Introduce files to project.pbxproj

Harbormaster completed remote builds in B10189: Diff 14067.Jul 1 2022, 2:17 AM
tomek accepted this revision.Jul 5 2022, 3:07 AM
tomek added inline comments.
native/ios/Comm/TemporalMessageStorage/TemporalMessageStorage.h
5 ↗(On Diff #14067)

I think temporary is preferred in this context

This revision is now accepted and ready to land.Jul 5 2022, 3:07 AM
marcin updated this revision to Diff 14154.Jul 5 2022, 3:22 AM

Rebase

Harbormaster failed remote builds in B10262: Diff 14154!Jul 5 2022, 3:22 AM
marcin updated this revision to Diff 14165.Jul 5 2022, 3:31 AM

Rebase master

Harbormaster completed remote builds in B10273: Diff 14165.Jul 5 2022, 4:51 AM
marcin updated this revision to Diff 14256.Jul 7 2022, 5:34 AM

Change initialization method signature and remove sanity check method

Harbormaster completed remote builds in B10348: Diff 14256.Jul 7 2022, 5:55 AM
marcin added inline comments.Jul 7 2022, 6:00 AM
native/ios/Comm/TemporalMessageStorage/TemporalMessageStorage.h
5 ↗(On Diff #14067)

Sure, I will do the renaming.

marcin updated this revision to Diff 14274.Jul 7 2022, 7:09 AM

Rename Temporal to Temporary

Harbormaster completed remote builds in B10366: Diff 14274.Jul 7 2022, 7:58 AM
marcin updated this revision to Diff 14467.Jul 14 2022, 4:49 AM

Rebase

This revision was landed with ongoing or failed builds.Jul 14 2022, 5:10 AM
Closed by commit rCOMM8f4ffc3eb09f: Define interface for flat-file based message storage operations (authored by marcin). · Explain Why
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM8f4ffc3eb09f: Define interface for flat-file based message storage operations.
Harbormaster completed remote builds in B10518: Diff 14467.Jul 14 2022, 5:20 AM

Revision Contents
Changeset List

PathSize
native/
ios/
Comm.xcodeproj/
2 lines
Comm/
TemporaryMessageStorage/
12 lines

Diff 14481

View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...
View Options

native/ios/Comm/TemporaryMessageStorage/TemporaryMessageStorage.h

Loading...