This differential uses TemporaryMessageStorage API to retrieve messages and store them in SQLite before JavaScript is started.
Details
Send several messages when mobile app is not running. Launch app in a debugger and ensure that all messages are retrieved from temporary message store. Then before last message is written to the database, download database from XCode and ensure that all messages seen so far are written to the database.
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
"temporal" is probably the wrong word here, I think you're looking for "temporary". Here is the definition of "temporal" according to Google:
"temporal" is probably the wrong word here, I think you're looking for "temporary". Here is the definition of "temporal" according to Google:
Understood, I will rename the class and refactor log messages if necessary.
native/ios/Comm/AppDelegate.mm | ||
---|---|---|
80 ↗ | (On Diff #14280) | Can this operation fail / throw an exception? We should probably avoid crashing the app if that happens. |
native/ios/Comm/AppDelegate.mm | ||
---|---|---|
80 ↗ | (On Diff #14280) | This operation is not expected to throw any exception we do not handle inside it implementation - filesystem and semaphore operations are handled inside its implementation, so I do not expect this operation to crash the app. On one hand it might be reasonable to add some try ... catch to prevent app from crashing in case I didn't predict all possible exceptions that might be thrown. On the other hand adding try ... catch might prevent us from being informed that there are some bugs, since application will still work correctly without this operation (though some messages might appear with delay during app startup). Therefore I would not add any try catch statement here |