Page MenuHomePhabricator

[Chore] Lint native/android/app/CMakeLists.txt
ClosedPublic

Authored by jon on Jul 18 2022, 4:23 PM.
Tags
None
Referenced Files
F3382827: D4568.id14598.diff
Thu, Nov 28, 12:09 PM
Unknown Object (File)
Sun, Nov 24, 5:47 PM
Unknown Object (File)
Sat, Nov 16, 9:06 AM
Unknown Object (File)
Sat, Nov 16, 9:03 AM
Unknown Object (File)
Thu, Oct 31, 4:23 PM
Unknown Object (File)
Oct 27 2024, 6:55 AM
Unknown Object (File)
Oct 27 2024, 6:55 AM
Unknown Object (File)
Oct 27 2024, 6:55 AM

Details

Summary

Lint android's CMakeLists.txt

Depends on D4564

Test Plan
nix develop
cmake-lint native/android/app/CMakeLists.txt
./gradlew bundleRelease --no-daemon # ensure build still passes

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 18 2022, 4:28 PM
Harbormaster failed remote builds in B10605: Diff 14598!

Defining the dirs separately makes a lot of sense – I assume you did that manually @jonringer-comm, but will be very impressed with the Linter if it does that automatically!

Separately, noticed that some of the lines here are longer than 80 chars, but for filenames I think it makes sense... it definitely hurts readability to split those across lines. Ideally we can have something that works like Prettier's printWidth setting, which generally limits line length but excludes import lines.

noticed that some of the lines here are longer than 80 chars, but for filenames I think it makes sense...

Strongly agree we shouldn't try splitting filenames in weird ways to stay within 80 char limit

This revision is now accepted and ready to land.Jul 19 2022, 11:01 AM

I assume you did that manually @jonringer-comm

I did it manually. The cmake-format command will mostly do whitespace and paren placement.