Page MenuHomePhabricator
Differential D4820

[native] set up CXX bridge
ClosedPublic
Actions

Authored by varun on Aug 11 2022, 8:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 3, 9:52 PM
Unknown Object (File)
Wed, Mar 26, 9:40 PM
Unknown Object (File)
Sat, Mar 22, 1:20 PM
Unknown Object (File)
Sun, Mar 16, 7:15 AM
Unknown Object (File)
Sat, Mar 15, 7:41 PM
Unknown Object (File)
Sat, Mar 15, 7:41 PM
Unknown Object (File)
Sat, Mar 15, 7:41 PM
Unknown Object (File)
Sat, Mar 15, 7:41 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• jon

Details

Reviewers
tomek
• karol
Commits
rCOMM3aecb610154d: [native] set up CXX bridge
Summary

create the ffi module that will be used to generate the bridge between C++ and Rust code

Depends on D4815

Test Plan

cargo build

Diff Detail

Repository
rCOMM Comm
Branch
identity-client (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Aug 11 2022, 8:43 PM
Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptAug 11 2022, 8:43 PM
Harbormaster completed remote builds in B11328: Diff 15588.Aug 11 2022, 8:53 PM
varun requested review of this revision.Aug 11 2022, 8:53 PM
varun added a child revision: D4821: [native] add corrosion to android cmake project.Aug 11 2022, 10:14 PM
tomek accepted this revision.Aug 12 2022, 3:56 AM
tomek added inline comments.
native/cpp/CommonCpp/grpc/grpc_client/build.rs
5

What os the purpose of this print?

This revision is now accepted and ready to land.Aug 12 2022, 3:56 AM
• karol accepted this revision.Aug 12 2022, 4:52 AM
• karol added inline comments.
native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs
51

What does ffi stand for? Can we change this name? It's not very descriptive.

ashoat added a comment.Aug 12 2022, 10:12 AM

https://en.wikipedia.org/wiki/Foreign_function_interface

• jon added a subscriber: • jon.Aug 12 2022, 10:14 AM
• jon added inline comments.
native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs
51

ffi is a pretty common across many languages, generally the assumption is that they "act like C", and that ABI can be used across many boundries.

varun added inline comments.Aug 12 2022, 11:14 AM
native/cpp/CommonCpp/grpc/grpc_client/build.rs
5

It tells Cargo that if the given file changes, to rerun this build script

native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs
51

I'd prefer to keep it as is

Closed by commit rCOMM3aecb610154d: [native] set up CXX bridge (authored by varun). · Explain WhyAug 18 2022, 11:34 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM3aecb610154d: [native] set up CXX bridge.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
grpc/
grpc_client/
2 lines
src/
3 lines

Diff 15588

View Options

native/cpp/CommonCpp/grpc/grpc_client/build.rs

Loading...
View Options

native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs

Loading...