Paths

Table of Contentst

Differential D4885

[services] Backup - Connect to Blob - Remove c++ part
ClosedPublic
Actions

Authored by • karol on Aug 19 2022, 1:31 AM.

Tags

None

Referenced Files

	F3535619: D4885.id15975.diff
	Wed, Dec 25, 4:36 PM

	F3530905: D4885.diff
	Wed, Dec 25, 5:09 AM

	Unknown Object (File)
	Tue, Dec 17, 9:02 AM

	Unknown Object (File)
	Sat, Dec 14, 7:03 AM

	Unknown Object (File)
	Sat, Dec 14, 7:03 AM

	Unknown Object (File)
	Sat, Dec 14, 7:03 AM

	Unknown Object (File)
	Sat, Dec 14, 7:02 AM

	Unknown Object (File)
	Sat, Dec 14, 6:54 AM

Subscribers

Details

Reviewers

tomek
• jon

Commits

rCOMM59672d15e9f3: [services] Backup - Connect to Blob - Remove c++ part

Summary

Depends on D4870

Removing c++ part responsible for handling the inner blob client calls in the backup service. Instead of using c++ for this, we agreed on using rust.

Test Plan

backup builds

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Aug 19 2022, 1:31 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptAug 19 2022, 1:31 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 19 2022, 1:32 AM

Harbormaster failed remote builds in B11472: Diff 15783!

• karol edited the summary of this revision. (Show Details)Aug 19 2022, 1:35 AM

• karol added a parent revision: D4870: [services] Backup - Rust lib - Add terminate.

• karol added a child revision: D4888: [services] Backup - Connect to Blob - split code to diferent files.Aug 19 2022, 7:29 AM

retrigger CI

Harbormaster completed remote builds in B11612: Diff 15975.Aug 25 2022, 5:08 AM

• karol requested review of this revision.Aug 25 2022, 5:08 AM

• karol edited the summary of this revision. (Show Details)Aug 29 2022, 1:28 AM

• karol edited the test plan for this revision. (Show Details)

• karol added a reviewer: tomek.

Herald added a reviewer: • jon. · View Herald TranscriptAug 29 2022, 1:28 AM

tomek accepted this revision.Aug 29 2022, 4:11 AM

tomek added inline comments.

services/backup/src/Reactors/server/PullBackupReactor.cpp
101–106 ↗	(On Diff #15975)	Is "dangling" data something specific to reactors approach? Why do we no longer need this check?

This revision is now accepted and ready to land.Aug 29 2022, 4:11 AM

• karol added inline comments.Aug 29 2022, 5:40 AM

services/backup/src/Reactors/server/PullBackupReactor.cpp
101–106 ↗	(On Diff #15975)	Yes, it is used in `BlobGetClientReactor` which we no longer will be using here. I've not done the `get` operation using rust so I cannot answer now how this will be handled in rust.

Closed by commit rCOMM59672d15e9f3: [services] Backup - Connect to Blob - Remove c++ part (authored by • karol). · Explain WhyAug 29 2022, 7:02 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM59672d15e9f3: [services] Backup - Connect to Blob - Remove c++ part.

Revision Contents
Changeset List

Path

Size

services/

backup/

5 lines

src/

Reactors/

client/

blob/

BlobGetClientReactor.h

BlobGetClientReactor.cpp

BlobPutClientReactor.h

BlobPutClientReactor.cpp

server/

AddAttachmentsUtility.cpp

21 lines

CreateNewBackupReactor.h

4 lines

CreateNewBackupReactor.cpp

26 lines

PullBackupReactor.h

10 lines

PullBackupReactor.cpp

48 lines

SendLogReactor.h

4 lines

SendLogReactor.cpp

29 lines

grpc-client/

ServiceBlobClient.h

Diff 15783

services/backup/CMakeLists.txt

Loading...

services/backup/src/Reactors/client/blob/BlobGetClientReactor.h

Loading...

services/backup/src/Reactors/client/blob/BlobGetClientReactor.cpp

Loading...

services/backup/src/Reactors/client/blob/BlobPutClientReactor.h

Loading...

services/backup/src/Reactors/client/blob/BlobPutClientReactor.cpp

Loading...

services/backup/src/Reactors/server/AddAttachmentsUtility.cpp

Loading...

services/backup/src/Reactors/server/CreateNewBackupReactor.h

Loading...

services/backup/src/Reactors/server/CreateNewBackupReactor.cpp

Loading...

services/backup/src/Reactors/server/PullBackupReactor.h

Loading...

services/backup/src/Reactors/server/PullBackupReactor.cpp

Loading...

services/backup/src/Reactors/server/SendLogReactor.h

Loading...

services/backup/src/Reactors/server/SendLogReactor.cpp

Loading...

services/backup/src/grpc-client/ServiceBlobClient.h

Loading...