Page MenuHomePhabricator

[services] Backup - Connect to Blob - Remove c++ part
ClosedPublic

Authored by karol on Aug 19 2022, 1:31 AM.
Tags
None
Referenced Files
F3269141: D4885.id15783.diff
Sat, Nov 16, 3:42 AM
Unknown Object (File)
Sun, Nov 10, 6:58 AM
Unknown Object (File)
Fri, Nov 8, 2:58 PM
Unknown Object (File)
Sun, Oct 27, 8:11 PM
Unknown Object (File)
Sun, Oct 27, 8:11 PM
Unknown Object (File)
Sun, Oct 27, 8:11 PM
Unknown Object (File)
Sun, Oct 27, 8:09 PM
Unknown Object (File)
Oct 8 2024, 8:04 AM

Details

Summary

Depends on D4870

Removing c++ part responsible for handling the inner blob client calls in the backup service. Instead of using c++ for this, we agreed on using rust.

Test Plan

backup builds

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 19 2022, 1:32 AM
Harbormaster failed remote builds in B11472: Diff 15783!
karol edited the test plan for this revision. (Show Details)
karol added a reviewer: tomek.
tomek added inline comments.
services/backup/src/Reactors/server/PullBackupReactor.cpp
101–106

Is "dangling" data something specific to reactors approach? Why do we no longer need this check?

This revision is now accepted and ready to land.Aug 29 2022, 4:11 AM
services/backup/src/Reactors/server/PullBackupReactor.cpp
101–106

Yes, it is used in BlobGetClientReactor which we no longer will be using here.

I've not done the get operation using rust so I cannot answer now how this will be handled in rust.