Paths

Table of Contentst

[native] remove unused types
ClosedPublic
Actions

Authored by varun on Aug 25 2022, 4:06 AM.

Tags

None

Referenced Files

	F3347688: D4951.diff
	Fri, Nov 22, 12:59 PM

	Unknown Object (File)
	Fri, Nov 8, 4:06 AM

	Unknown Object (File)
	Sat, Oct 26, 2:11 AM

	Unknown Object (File)
	Oct 23 2024, 9:59 AM

	Unknown Object (File)
	Oct 19 2024, 1:47 AM

	Unknown Object (File)
	Oct 19 2024, 1:47 AM

	Unknown Object (File)
	Oct 19 2024, 1:46 AM

	Unknown Object (File)
	Oct 19 2024, 1:39 AM

View All 91 Files

Subscribers

• abosh

ashoat

Details

Reviewers

tomek
• karol
atul

Commits

rCOMM3b5ea22263b5: [native] remove unused types

Summary

Introduced some types with the intention of simplifying our code but it proved too difficult. Removing them for now since they're unused.

Depends on D4950

Test Plan

cargo build

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Aug 25 2022, 4:06 AM

Herald added subscribers: • abosh, ashoat. · View Herald TranscriptAug 25 2022, 4:06 AM

Harbormaster completed remote builds in B11610: Diff 15973.Aug 25 2022, 4:16 AM

varun requested review of this revision.Aug 25 2022, 4:16 AM

varun added a child revision: D4953: [native] add Rust gRPC client to XCode project.Aug 25 2022, 5:35 AM

varun added 1 blocking reviewer(s): atul.Aug 25 2022, 10:31 AM

atul accepted this revision.Aug 25 2022, 11:12 AM

varun removed 1 blocking reviewer(s): tomek.Aug 25 2022, 11:13 AM

This revision is now accepted and ready to land.Aug 25 2022, 11:13 AM

Closed by commit rCOMM3b5ea22263b5: [native] remove unused types (authored by varun). · Explain WhyAug 25 2022, 11:34 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM3b5ea22263b5: [native] remove unused types.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

grpc/

grpc_client/

src/

lib.rs

21 lines

Diff 15992

View Options

native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs

[native] remove unused typesClosedPublicActions