Page MenuHomePhabricator

rust project for native blob gRPC client
AbandonedPublic

Authored by marcin on Sep 5 2022, 7:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 7:52 AM
Unknown Object (File)
Sun, Nov 17, 1:41 AM
Unknown Object (File)
Sat, Nov 9, 3:47 AM
Unknown Object (File)
Tue, Nov 5, 10:59 AM
Unknown Object (File)
Oct 10 2024, 2:24 PM
Unknown Object (File)
Oct 10 2024, 2:24 PM
Unknown Object (File)
Oct 10 2024, 2:24 PM
Unknown Object (File)
Oct 10 2024, 2:24 PM

Details

Summary

This differential initializes directory with rust library to exchange data with blob service in a way suitable for mobile devices. Cargo.toml is the only file that actually matters here.

Test Plan

Run cargo build from project root

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin requested review of this revision.Sep 5 2022, 7:46 AM
tomek added inline comments.
native/cpp/CommonCpp/grpc/blob_client/rust/Cargo.toml
10 ↗(On Diff #16328)

We should provide major and minor version.

Do we use all the provided features?

22 ↗(On Diff #16328)

Please add a new line

This revision is now accepted and ready to land.Sep 5 2022, 8:31 AM
native/cpp/CommonCpp/grpc/blob_client/rust/Cargo.toml
10 ↗(On Diff #16328)

You were right, in further diffs I do not need "macros", but the way I initialize runtime (@varun does it the same way) requires "rt-multi-thread"

Adding @ashoat because there are new dependencies

This revision now requires review to proceed.Sep 9 2022, 6:30 AM
In D5051#148862, @tomek wrote:

Adding @ashoat because there are new dependencies

All dependencies here are already in grpc_client/Cargo.toml from current master. Most probably entire blob client code will be merged into grpc_client as rust module.

jon requested changes to this revision.Sep 12 2022, 9:19 AM
jon added inline comments.
native/cpp/CommonCpp/grpc/blob_client/rust/Cargo.toml
2 ↗(On Diff #16407)

should give it a more appropriate name

This revision now requires changes to proceed.Sep 12 2022, 9:19 AM

I created this revision when I thought my blob client will be a separate binary. But since we agreed on creating one Rust crate for all native gRPC code, this revision will be abandoned once @varun refactors grpc_client. My blob client uses the same dependencies that are already used inside grpc_client so this revision will not be necessary. I do not think it is worth any reviewer time to review this.

This revision is now accepted and ready to land.Sep 16 2022, 12:55 PM

Refactor after varun's changes

Diff from 2022 what I was assigned encrypted blob upload work.