Paths

Table of Contentst

Differential D5117

[Services] Fix backup test suite build
ClosedPublic
Actions

Authored by • jon on Sep 12 2022, 1:45 PM.

Tags

None

Referenced Files

	F3247095: D5117.id16606.diff
	Fri, Nov 15, 3:29 AM

	F3246716: D5117.diff
	Fri, Nov 15, 1:37 AM

	Unknown Object (File)
	Sun, Oct 27, 6:12 AM

	Unknown Object (File)
	Oct 9 2024, 8:39 PM

	Unknown Object (File)
	Oct 9 2024, 3:17 AM

	Unknown Object (File)
	Oct 8 2024, 1:13 AM

	Unknown Object (File)
	Oct 8 2024, 1:13 AM

	Unknown Object (File)
	Oct 8 2024, 1:13 AM

Subscribers

Details

Reviewers

atul
• abosh
varun
• max
• karol

Commits

rCOMMf3f886ab6d54: [Services] Fix backup test suite build

Summary

I would like to add the test suites to the CI, but they have to
build first

Also, a big change is building the testsuite by default, however, this is
the common practice, and generally people opt-out of building tests by doing
-DBUILD_TESTING=OFF when they invoke cmake.

https://linear.app/comm/issue/ENG-1794

Test Plan

nix develop
cd services/backup
rm -rf build && mkdir build && cd build && cmake .. && make -j
ctest # should fail as AWS needs to be configured, but run

# without tests
nix develop
cd services/backup
rm -rf build && mkdir build && cd build && cmake .. -DBUILD_TESTING=OFF && make -j
ctest # should fail to find tests

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Sep 12 2022, 1:45 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 12 2022, 1:45 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 12 2022, 1:46 PM

Harbormaster failed remote builds in B12092: Diff 16599!

• jon added a parent revision: D5121: [Services] Avoid using GTest in docker.Sep 12 2022, 2:04 PM

Rebase on top of docker fixes

force gtest to be found through config, to void libgtest.a being found

Harbormaster completed remote builds in B12099: Diff 16606.Sep 12 2022, 2:13 PM

Harbormaster completed remote builds in B12103: Diff 16610.Sep 12 2022, 2:19 PM

• jon requested review of this revision.Sep 12 2022, 2:19 PM

Was able to successfully follow Test Plan both with and without tests.

This revision is now accepted and ready to land.Sep 13 2022, 9:16 AM

Closed by commit rCOMMf3f886ab6d54: [Services] Fix backup test suite build (authored by • jon). · Explain WhySep 13 2022, 11:45 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMf3f886ab6d54: [Services] Fix backup test suite build.

Revision Contents
Changeset List

Path

Size

services/

backup/

40 lines

Diff 16629

services/backup/CMakeLists.txt

Loading...