[Chore] Cleanup blob CMakeLists.txt
ClosedPublic
Actions

Authored by • jon on Sep 12 2022, 1:51 PM.

Details

Reviewers

atul
• abosh
varun
• max
• karol

Commits

rCOMMdcc1dc7431e6: [Chore] Cleanup blob CMakeLists.txt

Summary

Noticed some dead code from D4493

Test Plan

blob CI passes

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Sep 12 2022, 1:51 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 12 2022, 1:51 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 12 2022, 1:52 PM

Harbormaster failed remote builds in B12095: Diff 16602!

• jon added a parent revision: D5116: [Services] Fix blob test build.Sep 12 2022, 2:04 PM

Rebase on top of docker fixes

Harbormaster completed remote builds in B12102: Diff 16609.Sep 12 2022, 2:17 PM

• jon requested review of this revision.Sep 12 2022, 2:17 PM

In addition to blob CI, was able to run docker-compose build --no-cache blob-server successfully on Apple silicon

This revision is now accepted and ready to land.Sep 13 2022, 9:37 AM

Closed by commit rCOMMdcc1dc7431e6: [Chore] Cleanup blob CMakeLists.txt (authored by • jon). · Explain WhySep 13 2022, 11:45 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMdcc1dc7431e6: [Chore] Cleanup blob CMakeLists.txt.

Revision Contents
Changeset List

Path

Size

services/

blob/

CMakeLists.txt

13 lines

Diff 16633

View Options

services/blob/CMakeLists.txt

[Chore] Cleanup blob CMakeLists.txtClosedPublicActions