Paths

Table of Contentst

[CommCoreModule] Cut extraneous `include`s
ClosedPublic
Actions

Authored by atul on Oct 4 2022, 6:27 PM.

Details

Reviewers

tomek
marcin
• abosh
rohan
ginsu
• jon

Commits

rCOMM2e9ead6b523e: [CommCoreModule] Cut extraneous `include`s

Summary

Noticed these while working on the "C++ side" of native.

Test Plan

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Oct 4 2022, 6:27 PM

Herald added a reviewer: • jon. · View Herald TranscriptOct 4 2022, 6:27 PM

Herald added a subscriber: ashoat. · View Herald Transcript

Harbormaster completed remote builds in B12607: Diff 17331.Oct 4 2022, 6:38 PM

atul requested review of this revision.Oct 4 2022, 6:38 PM

tomek accepted this revision.Oct 5 2022, 1:56 AM

This revision is now accepted and ready to land.Oct 5 2022, 1:56 AM

rohan accepted this revision.Oct 5 2022, 3:31 AM

marcin accepted this revision.Oct 5 2022, 3:33 AM

rebase before landing

This revision was landed with ongoing or failed builds.Oct 5 2022, 7:47 AM

Closed by commit rCOMM2e9ead6b523e: [CommCoreModule] Cut extraneous `include`s (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM2e9ead6b523e: [CommCoreModule] Cut extraneous `include`s.

Harbormaster completed remote builds in B12631: Diff 17359.Oct 5 2022, 7:55 AM

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

SQLiteQueryExecutor.cpp

9 lines

NativeModules/

CommCoreModule.cpp

6 lines

Diff 17331

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp