Differential D5488

[Nix] Fix whitespace quoting for path
ClosedPublic
Actions

Authored by • jon on Oct 26 2022, 1:35 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jan 1, 5:44 PM

	Unknown Object (File)
	Wed, Jan 1, 5:44 PM

	Unknown Object (File)
	Wed, Jan 1, 5:43 PM

	Unknown Object (File)
	Wed, Jan 1, 5:35 PM

	Unknown Object (File)
	Wed, Jan 1, 4:38 PM

	Unknown Object (File)
	Fri, Dec 27, 12:10 PM

	Unknown Object (File)
	Tue, Dec 10, 6:37 AM

	Unknown Object (File)
	Nov 25 2024, 3:47 AM

Subscribers

Details

Reviewers

atul
varun

Commits

rCOMM9fee06a231c0: [Nix] Fix whitespace quoting for path

Summary

If a user has a path with whitespace, avoid having the
string split when passed to export command.

Test Plan

export PATH="/a b:$PATH"

nix develop

source ~/.cache/comm/path
# don't get error from export

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Oct 26 2022, 1:35 PM

Herald added subscribers: • abosh, tomek, ashoat. · View Herald TranscriptOct 26 2022, 1:36 PM

• jon added a child revision: D5478: [Nix] Provide iOS specific dev shell.Oct 26 2022, 1:37 PM

Harbormaster completed remote builds in B13053: Diff 17925.Oct 26 2022, 1:49 PM

• jon requested review of this revision.Oct 26 2022, 1:49 PM

👍🏽

This revision is now accepted and ready to land.Oct 26 2022, 2:35 PM

• jon added a child revision: D5508: [iOS] Fix pod install and react-native with nix env.Oct 31 2022, 7:17 AM

• jon removed a child revision: D5478: [Nix] Provide iOS specific dev shell.Oct 31 2022, 7:43 AM

Closed by commit rCOMM9fee06a231c0: [Nix] Fix whitespace quoting for path (authored by • jon). · Explain WhyNov 3 2022, 9:46 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM9fee06a231c0: [Nix] Fix whitespace quoting for path.

Revision Contents
Changeset List

Path

Size

scripts/

2 lines

Diff 17925

scripts/save_path.sh

Loading...