[native] Add `jcenter()` as fallback for `gradlePluginPortal()`
ClosedPublic
Actions

Authored by atul on Nov 7 2022, 4:52 PM.

Details

Reviewers

varun
ashoat
tomek
marcin
rohan
ginsu

Commits

rCOMM249757e038eb: [native] Add `jcenter()` as fallback for `gradlePluginPortal()`

Summary

In a previous diff I removed jcenter() and replaced it with gradlePluginPortal() since jcenter() is (one day) going to be taken down and has been a source of issues in the past.

However... we're now experiencing issues with the Gradle Plugin Portal: https://status.gradle.com/incidents/9j9bx7nlwwf1

I wonder if adding jcenter() as a fallback will resolve things (at least in the short tun)

NOTE: I plan on reverting this in a few days once whatever intermittent Gradle issue is over.

Test Plan

See if Android CI passes

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Nov 7 2022, 4:52 PM

Herald added a subscriber: • abosh. · View Herald TranscriptNov 7 2022, 4:52 PM

atul edited the summary of this revision. (Show Details)Nov 7 2022, 4:52 PM

Harbormaster completed remote builds in B13240: Diff 18167.Nov 7 2022, 5:06 PM

atul requested review of this revision.Nov 7 2022, 5:06 PM

NOTE: I plan on reverting this in a few days once whatever intermittent Gradle issue is over.

Is that a good idea? Seems like this sort of downtime is like a regular thing with these Android package hosts... maybe we keep both of them around just in case? Or does that slow down builds or something?

This revision is now accepted and ready to land.Nov 7 2022, 5:51 PM

In D5551#164512, @ashoat wrote:

NOTE: I plan on reverting this in a few days once whatever intermittent Gradle issue is over.

Is that a good idea? Seems like this sort of downtime is like a regular thing with these Android package hosts... maybe we keep both of them around just in case? Or does that slow down builds or something?

By leaving it off the list we'll be alerted (by a build failure) if some dependency can only be resolved via jcenter() (since TIL Gradle Plugin Portal isn't a "complete" mirror...).

I'll land as-is and we can see how things go w/ Android dependency reliability

rebase before landing

Harbormaster completed remote builds in B13244: Diff 18171.Nov 7 2022, 7:33 PM

Closed by commit rCOMM249757e038eb: [native] Add `jcenter()` as fallback for `gradlePluginPortal()` (authored by atul). · Explain WhyNov 7 2022, 7:34 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM249757e038eb: [native] Add `jcenter()` as fallback for `gradlePluginPortal()`.

In D5551#164527, @atul wrote:

In D5551#164512, @ashoat wrote:

NOTE: I plan on reverting this in a few days once whatever intermittent Gradle issue is over.

Is that a good idea? Seems like this sort of downtime is like a regular thing with these Android package hosts... maybe we keep both of them around just in case? Or does that slow down builds or something?

By leaving it off the list we'll be alerted (by a build failure) if some dependency can only be resolved via jcenter() (since TIL Gradle Plugin Portal isn't a "complete" mirror...).