Page MenuHomePhabricator
Differential D5612

[native] Fix appearance of `AppsDirectory` in light mode
ClosedPublic
Actions

Authored by atul on Nov 10 2022, 5:36 PM.
Tags
None
Referenced Files
F2897416: D5612.id18366.diff
Fri, Oct 4, 11:20 PM
F2896940: D5612.diff
Fri, Oct 4, 9:24 PM
Unknown Object (File)
Wed, Oct 2, 5:29 PM
Unknown Object (File)
Thu, Sep 19, 6:21 AM
Unknown Object (File)
Thu, Sep 19, 6:21 AM
Unknown Object (File)
Thu, Sep 19, 6:21 AM
Unknown Object (File)
Thu, Sep 19, 6:20 AM
Unknown Object (File)
Thu, Sep 19, 6:16 AM
View All 66 Files
Subscribers
ashoat

Details

Reviewers
tomek
marcin
ginsu
rohan
• abosh
varun
ashoat
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rCOMM2abfa7632b3a: [native] Fix appearance of `AppsDirectory` in light mode
Summary

Context: https://linear.app/comm/issue/ENG-2052/re-introduce-light-mode-in-native

Use colors from colors.js instead of hardcoded hex values. Don't think the color choice for modalBackground in light mode is great... but that can be addressed later. This is more about having the UI handle both light/dark mode "reasonably."

Test Plan

Before:

ea5a87.png (1×714 px, 288 KB)

After:

f29a00.png (1×732 px, 274 KB)

Things look as expected.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Nov 10 2022, 5:36 PM
Herald added a subscriber: ashoat. · View Herald TranscriptNov 10 2022, 5:36 PM
atul edited the test plan for this revision. (Show Details)Nov 10 2022, 5:37 PM
atul updated this revision to Diff 18366.Nov 10 2022, 5:38 PM

actually panelBackground is better than modalBackground

atul edited the test plan for this revision. (Show Details)Nov 10 2022, 5:38 PM
Harbormaster completed remote builds in B13390: Diff 18365.Nov 10 2022, 5:49 PM
Harbormaster completed remote builds in B13391: Diff 18366.Nov 10 2022, 5:52 PM
atul requested review of this revision.Nov 10 2022, 5:52 PM
rohan accepted this revision.Nov 11 2022, 8:03 AM
This revision is now accepted and ready to land.Nov 11 2022, 8:03 AM
atul added a reviewer: Restricted Owners Package.Nov 11 2022, 8:05 AM
This revision now requires review to proceed.Nov 11 2022, 8:05 AM
ginsu accepted this revision.Nov 11 2022, 8:38 AM
ashoat accepted this revision.Nov 11 2022, 1:01 PM
This revision is now accepted and ready to land.Nov 11 2022, 1:01 PM
Closed by commit rCOMM2abfa7632b3a: [native] Fix appearance of `AppsDirectory` in light mode (authored by atul). · Explain WhyNov 11 2022, 1:09 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM2abfa7632b3a: [native] Fix appearance of `AppsDirectory` in light mode.

Revision Contents
Changeset List

PathSize
native/
apps/
4 lines

Diff 18365

View Options

native/apps/apps-directory.react.js

Loading...