Paths

Table of Contentst

Differential D5636

[lib] Update `rawMessageInfoFromClientDB` preconditions to allow `MULTIMEDIA` messages.
ClosedPublic
Actions

Authored by atul on Nov 15 2022, 6:10 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 13, 8:24 AM

	Unknown Object (File)
	Tue, Nov 12, 6:39 PM

	Unknown Object (File)
	Tue, Nov 12, 4:56 AM

	Unknown Object (File)
	Tue, Nov 12, 4:00 AM

	Unknown Object (File)
	Tue, Nov 12, 3:47 AM

	Unknown Object (File)
	Tue, Nov 12, 3:42 AM

	Unknown Object (File)
	Tue, Nov 12, 3:29 AM

	Unknown Object (File)
	Tue, Nov 12, 3:23 AM

Subscribers

Details

Reviewers

tomek
marcin
ginsu
rohan
kamil
ashoat

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rCOMMc9f972fac72f: [lib] Update `rawMessageInfoFromClientDB` preconditions to allow `MULTIMEDIA`…

Summary

invariant at start of rawMessageInfoFromClientDB currently always fails for messages of type MULTIMEDIA. This diff updates the invariant to accept either MULTIMEDIA or IMAGES messages.

Actual handling of MULTIMEDIA messages will come in a subsequent diff... this is mostly just to put up changes that can be landed as-is to reduce number of changes I have to juggle locally.

Test Plan

Things continue to work as expected.

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Nov 15 2022, 6:10 PM

Herald added subscribers: • abosh, ashoat. · View Herald TranscriptNov 15 2022, 6:10 PM

Harbormaster completed remote builds in B13449: Diff 18448.Nov 15 2022, 6:23 PM

atul requested review of this revision.Nov 15 2022, 6:23 PM

atul added a child revision: D5637: [lib] Update `rawMessageInfoFromClientDB` to handle both `IMAGES` and `MULTIMEDIA` message types.Nov 15 2022, 7:03 PM

atul added a reviewer: Restricted Owners Package.Nov 16 2022, 2:55 PM

ashoat accepted this revision.Nov 16 2022, 8:11 PM

This revision is now accepted and ready to land.Nov 16 2022, 8:11 PM

rebase before landing

This revision was landed with ongoing or failed builds.Nov 17 2022, 10:04 AM

Closed by commit rCOMMc9f972fac72f: [lib] Update `rawMessageInfoFromClientDB` preconditions to allow `MULTIMEDIA`… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMc9f972fac72f: [lib] Update `rawMessageInfoFromClientDB` preconditions to allow `MULTIMEDIA`….

Harbormaster completed remote builds in B13523: Diff 18532.Nov 17 2022, 10:11 AM

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

multimedia-message-spec.js

11 lines

Diff 18448

lib/shared/messages/multimedia-message-spec.js

Loading...