Page MenuHomePhabricator
Differential D5639

[services] Tunnelbroker - Expose config to the Rust
ClosedPublic
Actions

Authored by • max on Nov 16 2022, 3:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 13, 4:20 PM
Unknown Object (File)
Thu, Mar 20, 1:34 PM
Unknown Object (File)
Mar 10 2025, 2:40 PM
Unknown Object (File)
Mar 3 2025, 4:36 AM
Unknown Object (File)
Mar 3 2025, 4:36 AM
Unknown Object (File)
Mar 3 2025, 4:36 AM
Unknown Object (File)
Feb 12 2025, 8:21 PM
Unknown Object (File)
Feb 12 2025, 9:43 AM
View All Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
• jon
varun
Commits
rCOMMf863b716e483: [services] Tunnelbroker - Expose config to the Rust
Summary

In this diff, we are exposing a function to get the parameter from the config file from the C++ codebase to the Rust codebase as a getConfigParameter function.
This function will be used in the Rust codebase diff D5641 and forward.

Linear task: ENG-1893

Test Plan
  1. Service is successfully built.
  2. The diff D5641 where the function is used the service is successfully built.

Diff Detail

Repository
rCOMM Comm
Branch
expose-config-to-rust
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• max created this revision.Nov 16 2022, 3:17 AM
• max held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptNov 16 2022, 3:17 AM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript
• max added a child revision: D5640: [services] Tunnelbroker - Expose `isSandbox` to the Rust.Nov 16 2022, 3:19 AM
Harbormaster failed remote builds in B13459: Diff 18458!Nov 16 2022, 3:19 AM
• max edited the summary of this revision. (Show Details)Nov 16 2022, 4:42 AM
• max edited the test plan for this revision. (Show Details)
• max added a reviewer: tomek.
• max edited the summary of this revision. (Show Details)
• max edited reviewers, added: varun; removed: tomek. • max added 1 blocking reviewer(s): • jon.
Harbormaster completed remote builds in B13459: Diff 18458.Nov 16 2022, 4:44 AM
• max published this revision for review.Nov 16 2022, 4:44 AM
• jon accepted this revision.Nov 16 2022, 2:56 PM

okay with this as a transition away from C++

This revision is now accepted and ready to land.Nov 16 2022, 2:56 PM
Closed by commit rCOMMf863b716e483: [services] Tunnelbroker - Expose config to the Rust (authored by • max). · Explain WhyNov 19 2022, 4:04 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMMf863b716e483: [services] Tunnelbroker - Expose config to the Rust.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
1 line
libcpp/
1 line
6 lines

Diff 18458

View Options

services/tunnelbroker/src/cxx_bridge.rs

// @flow // @flow
import { setClientDBStoreActionType } from '../actions/client-db-store-actions.js'; import { setClientDBStoreActionType } from '../actions/client-db-store-actions.js';
import { addCommunityActionType } from '../actions/community-actions.js'; import {
addCommunityActionType,
fetchCommunityInfosActionTypes,
createOrUpdateFarcasterChannelTagActionTypes,
deleteFarcasterChannelTagActionTypes,
} from '../actions/community-actions.js';
import { import {
communityStoreOpsHandlers, communityStoreOpsHandlers,
type CommunityStoreOperation, type CommunityStoreOperation,
type ReplaceCommunityOperation, type ReplaceCommunityOperation,
} from '../ops/community-store-ops.js'; } from '../ops/community-store-ops.js';
import type { CommunityStore } from '../types/community-types.js'; import type { CommunityStore } from '../types/community-types.js';
import type { BaseAction } from '../types/redux-types'; import type { BaseAction } from '../types/redux-types';
const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers; const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers;
function reduceCommunityStore( function reduceCommunityStore(
state: CommunityStore, state: CommunityStore,
action: BaseAction, action: BaseAction,
): { ): {
+communityStore: CommunityStore, +communityStore: CommunityStore,
+communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>, +communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>,
} { } {
if (action.type === addCommunityActionType) { if (action.type === fetchCommunityInfosActionTypes.success) {
const replaceOperations = action.payload.communityInfos.map(community => {
const { id, ...communityInfo } = community;
return {
type: 'replace_community',
payload: {
id,
communityInfo,
},
};
});
return {
communityStore: processStoreOps(state, replaceOperations),
communityStoreOperations: replaceOperations,
};
} else if (
action.type === createOrUpdateFarcasterChannelTagActionTypes.success
) {
const communityID = action.payload.commCommunityID;
const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community',
payload: {
id: communityID,
communityInfo: {
...state.communityInfos[communityID],
farcasterChannelID: action.payload.farcasterChannelID,
},
},
};
return {
communityStore: processStoreOps(state, [replaceOperation]),
communityStoreOperations: [replaceOperation],
};
} else if (action.type === deleteFarcasterChannelTagActionTypes.success) {
const communityID = action.payload.commCommunityID;
const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community',
payload: {
id: communityID,
communityInfo: {
...state.communityInfos[communityID],
farcasterChannelID: null,
},
},
};
return {
communityStore: processStoreOps(state, [replaceOperation]),
communityStoreOperations: [replaceOperation],
};
} else if (action.type === addCommunityActionType) {
const replaceOperation: ReplaceCommunityOperation = { const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community', type: 'replace_community',
payload: { payload: {
id: action.payload.id, id: action.payload.id,
communityInfo: action.payload.newCommunityInfo, communityInfo: action.payload.newCommunityInfo,
}, },
}; };
Show All 32 Lines
View Options

services/tunnelbroker/src/libcpp/Tunnelbroker.h

// @flow // @flow
import { setClientDBStoreActionType } from '../actions/client-db-store-actions.js'; import { setClientDBStoreActionType } from '../actions/client-db-store-actions.js';
import { addCommunityActionType } from '../actions/community-actions.js'; import {
addCommunityActionType,
fetchCommunityInfosActionTypes,
createOrUpdateFarcasterChannelTagActionTypes,
deleteFarcasterChannelTagActionTypes,
} from '../actions/community-actions.js';
import { import {
communityStoreOpsHandlers, communityStoreOpsHandlers,
type CommunityStoreOperation, type CommunityStoreOperation,
type ReplaceCommunityOperation, type ReplaceCommunityOperation,
} from '../ops/community-store-ops.js'; } from '../ops/community-store-ops.js';
import type { CommunityStore } from '../types/community-types.js'; import type { CommunityStore } from '../types/community-types.js';
import type { BaseAction } from '../types/redux-types'; import type { BaseAction } from '../types/redux-types';
const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers; const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers;
function reduceCommunityStore( function reduceCommunityStore(
state: CommunityStore, state: CommunityStore,
action: BaseAction, action: BaseAction,
): { ): {
+communityStore: CommunityStore, +communityStore: CommunityStore,
+communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>, +communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>,
} { } {
if (action.type === addCommunityActionType) { if (action.type === fetchCommunityInfosActionTypes.success) {
const replaceOperations = action.payload.communityInfos.map(community => {
const { id, ...communityInfo } = community;
return {
type: 'replace_community',
payload: {
id,
communityInfo,
},
};
});
return {
communityStore: processStoreOps(state, replaceOperations),
communityStoreOperations: replaceOperations,
};
} else if (
action.type === createOrUpdateFarcasterChannelTagActionTypes.success
) {
const communityID = action.payload.commCommunityID;
const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community',
payload: {
id: communityID,
communityInfo: {
...state.communityInfos[communityID],
farcasterChannelID: action.payload.farcasterChannelID,
},
},
};
return {
communityStore: processStoreOps(state, [replaceOperation]),
communityStoreOperations: [replaceOperation],
};
} else if (action.type === deleteFarcasterChannelTagActionTypes.success) {
const communityID = action.payload.commCommunityID;
const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community',
payload: {
id: communityID,
communityInfo: {
...state.communityInfos[communityID],
farcasterChannelID: null,
},
},
};
return {
communityStore: processStoreOps(state, [replaceOperation]),
communityStoreOperations: [replaceOperation],
};
} else if (action.type === addCommunityActionType) {
const replaceOperation: ReplaceCommunityOperation = { const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community', type: 'replace_community',
payload: { payload: {
id: action.payload.id, id: action.payload.id,
communityInfo: action.payload.newCommunityInfo, communityInfo: action.payload.newCommunityInfo,
}, },
}; };
Show All 32 Lines
View Options

services/tunnelbroker/src/libcpp/Tunnelbroker.cpp

// @flow // @flow
import { setClientDBStoreActionType } from '../actions/client-db-store-actions.js'; import { setClientDBStoreActionType } from '../actions/client-db-store-actions.js';
import { addCommunityActionType } from '../actions/community-actions.js'; import {
addCommunityActionType,
fetchCommunityInfosActionTypes,
createOrUpdateFarcasterChannelTagActionTypes,
deleteFarcasterChannelTagActionTypes,
} from '../actions/community-actions.js';
import { import {
communityStoreOpsHandlers, communityStoreOpsHandlers,
type CommunityStoreOperation, type CommunityStoreOperation,
type ReplaceCommunityOperation, type ReplaceCommunityOperation,
} from '../ops/community-store-ops.js'; } from '../ops/community-store-ops.js';
import type { CommunityStore } from '../types/community-types.js'; import type { CommunityStore } from '../types/community-types.js';
import type { BaseAction } from '../types/redux-types'; import type { BaseAction } from '../types/redux-types';
const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers; const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers;
function reduceCommunityStore( function reduceCommunityStore(
state: CommunityStore, state: CommunityStore,
action: BaseAction, action: BaseAction,
): { ): {
+communityStore: CommunityStore, +communityStore: CommunityStore,
+communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>, +communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>,
} { } {
if (action.type === addCommunityActionType) { if (action.type === fetchCommunityInfosActionTypes.success) {
const replaceOperations = action.payload.communityInfos.map(community => {
const { id, ...communityInfo } = community;
return {
type: 'replace_community',
payload: {
id,
communityInfo,
},
};
});
return {
communityStore: processStoreOps(state, replaceOperations),
communityStoreOperations: replaceOperations,
};
} else if (
action.type === createOrUpdateFarcasterChannelTagActionTypes.success
) {
const communityID = action.payload.commCommunityID;
const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community',
payload: {
id: communityID,
communityInfo: {
...state.communityInfos[communityID],
farcasterChannelID: action.payload.farcasterChannelID,
},
},
};
return {
communityStore: processStoreOps(state, [replaceOperation]),
communityStoreOperations: [replaceOperation],
};
} else if (action.type === deleteFarcasterChannelTagActionTypes.success) {
const communityID = action.payload.commCommunityID;
const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community',
payload: {
id: communityID,
communityInfo: {
...state.communityInfos[communityID],
farcasterChannelID: null,
},
},
};
return {
communityStore: processStoreOps(state, [replaceOperation]),
communityStoreOperations: [replaceOperation],
};
} else if (action.type === addCommunityActionType) {
const replaceOperation: ReplaceCommunityOperation = { const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community', type: 'replace_community',
payload: { payload: {
id: action.payload.id, id: action.payload.id,
communityInfo: action.payload.newCommunityInfo, communityInfo: action.payload.newCommunityInfo,
}, },
}; };
Show All 32 Lines