Paths

Table of Contentst

-
services/tunnelbroker/src/notifications/
-
tunnelbroker/
-
src/
-
notifications/
1/1
config.rs
1/1
mod.rs

[services] Tunnelbroker - Notifications config initialization
ClosedPublic
Actions

Authored by • max on Nov 16 2022, 3:20 AM.

Details

Reviewers

• jon
tomek
varun

Commits

rCOMMd22cf359cf99: [services] Tunnelbroker - Notifications config initialization

Summary

In this diff, we initialize the static configuration as a struct for the internal notifications library to avoid passing repeated parameters on every notification-sending call. We are using a lazy static initialization and parameters from the Tunnelbroker's configuration file.
This diff is related to the abandoned D5329. The static configuration is used in the D5642 diff updates.

Linear task: ENG-1737

Test Plan

Service is successfully built.
The diff D5641 where the function is used the service is successfully built.

Diff Detail

Repository

rCOMM Comm

Branch

notifs-config-initialization

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Nov 16 2022, 3:20 AM

• max held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptNov 16 2022, 3:20 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

• max added a parent revision: D5640: [services] Tunnelbroker - Expose `isSandbox` to the Rust.Nov 16 2022, 3:21 AM

Harbormaster completed remote builds in B13461: Diff 18460.Nov 16 2022, 3:32 AM

• max mentioned this in D5639: [services] Tunnelbroker - Expose config to the Rust.Nov 16 2022, 4:42 AM

• max mentioned this in D5640: [services] Tunnelbroker - Expose `isSandbox` to the Rust.Nov 16 2022, 4:45 AM

• max edited the summary of this revision. (Show Details)Nov 16 2022, 4:51 AM

• max edited the test plan for this revision. (Show Details)

• max added reviewers: tomek, varun.

• max mentioned this in D5642: [services] Tunnelbroker - Updating notifications libraries with the config.Nov 16 2022, 5:23 AM

• max mentioned this in D5329: [services] Tunnelbroker - Add `init` function to the Rust notification library.Nov 16 2022, 5:33 AM

Adding @tomek here as this diff is a follow-up from the abandoned D5329 and D5330 that are passed the first pass.

• max added a child revision: D5642: [services] Tunnelbroker - Updating notifications libraries with the config.Nov 16 2022, 5:38 AM

I'm okay with this for now. https://phab.comm.dev/D5640#167758 Applies to this as well, but this looks to be moving in the right direction.

tomek accepted this revision.Nov 17 2022, 3:32 AM

This revision is now accepted and ready to land.Nov 17 2022, 3:32 AM

• max mentioned this in rCOMMf863b716e483: [services] Tunnelbroker - Expose config to the Rust.Nov 19 2022, 4:04 AM

Closed by commit rCOMMd22cf359cf99: [services] Tunnelbroker - Notifications config initialization (authored by • max). · Explain WhyNov 19 2022, 4:11 AM

This revision was automatically updated to reflect the committed changes.

• max mentioned this in rCOMMdc959d543158: [services] Tunnelbroker - Expose `isSandbox` to the Rust.

• max added a commit: rCOMMd22cf359cf99: [services] Tunnelbroker - Notifications config initialization.

• max mentioned this in rCOMMd837bd2529d9: [services] Tunnelbroker - Updating notifications libraries with the config.Nov 19 2022, 4:59 AM

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

notifications/

config.rs

8 lines

mod.rs

21 lines

Diff 18460

View Options

services/tunnelbroker/src/notifications/config.rs

	// @flow			// @flow

	import * as React from 'react';			import * as React from 'react';

	import { assetMetaData } from './asset-meta-data.js';			import { assetMetaData } from './asset-meta-data.js';
	import HeroContent from './hero-content.react.js';			import HeroContent from './hero-content.react.js';
	import InfoBlock from './info-block.react.js';
	ginsuAuthorUnsubmitted Done Inline Actions Even though, there are currently no uses of `InfoBlock` we don't want to completely remove the component since the plan is to repurpose the component in a subsequent diff ginsu: Even though, there are currently no uses of `InfoBlock` we don't want to completely remove the…
	import css from './landing.css';			import css from './landing.css';
	import Picture from './Picture.react.js';			import Picture from './Picture.react.js';
	import usePreloadAssets from './use-pre-load-assets.react.js';			import usePreloadAssets from './use-pre-load-assets.react.js';

	function AppLanding(): React.Node {			function AppLanding(): React.Node {
	usePreloadAssets(assetMetaData);			usePreloadAssets(assetMetaData);
	const [			const [hero] = assetMetaData;
	hero,
	federated,
	customizable,
	encrypted,
	sovereign,
	openSource,
	lessNoisy,
	] = assetMetaData;

	return (			return (
	<main className={css.wrapper}>			<main className={css.wrapper}>
	<div className={hero.imageStyle}>			<div className={hero.imageStyle}>
	<Picture url={hero.url} alt={hero.alt} />			<Picture url={hero.url} alt={hero.alt} />
	</div>			</div>
	<HeroContent />			<HeroContent />
	<InfoBlock {...federated} />
	<InfoBlock {...customizable} />
	<InfoBlock {...encrypted} />
	<InfoBlock {...sovereign} />
	<InfoBlock {...openSource} />
	<InfoBlock {...lessNoisy} />
	</main>			</main>
	);			);
	}			}

	export default AppLanding;			export default AppLanding;