Page MenuHomePhabricator

[services][blob] Initial commit for Rust service
ClosedPublic

Authored by bartek on Nov 18 2022, 8:06 AM.
Tags
None
Referenced Files
F3506043: D5676.id18933.diff
Fri, Dec 20, 3:33 PM
F3506029: D5676.id18576.diff
Fri, Dec 20, 3:29 PM
F3505893: D5676.id18798.diff
Fri, Dec 20, 2:57 PM
F3504963: D5676.diff
Fri, Dec 20, 11:35 AM
Unknown Object (File)
Sun, Dec 15, 5:50 PM
Unknown Object (File)
Sun, Dec 15, 5:50 PM
Unknown Object (File)
Sun, Dec 15, 5:50 PM
Unknown Object (File)
Sun, Dec 15, 5:49 PM
Subscribers

Details

Summary

This is my first project in Rust and I am new to the language,
so I wrote a classic hello-world app ;)

Initialized a fresh Rust project and set up generating code from proto.

Depends on D5675

Test Plan
cd services/blob
cargo run

should build and display hello world

Diff Detail

Repository
rCOMM Comm
Branch
barthap/blob-rust
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Nov 18 2022, 9:20 AM
bartek added inline comments.
services/blob/Cargo.toml
7

Should be 2021 - noticed that I didn't commit this typo fix here - it is fixed two diffs later

varun added inline comments.
services/blob/Cargo.toml
7

I think it'd be better to just fix it here and rebase your stack

This revision is now accepted and ready to land.Nov 18 2022, 11:42 AM
services/blob/Cargo.toml
7

it is fixed two diffs later

This is a big anti-pattern in the stacked diffs workflow. Unless it's extremely difficult, you should always aim to update the diff where the issue was introduced, rather than asking the reviewer to reference a later diff to see where it was fixed

services/blob/Cargo.toml
7

Ok, fine. I'll do it here.

Accepting, but please update the edition before landing

Fix typo in cargo.toml edition field