Until the Rust implementation is complete, the current C++ implementation
can live next to it.
- Moved the C++ Blob Service code to the services/blob/cpp directory
- Adjusted Dockerfile and CMakeLists.txt to use the new location
Differential D5675 Authored by bartek on Nov 18 2022, 7:55 AM.
Details Summary Until the Rust implementation is complete, the current C++ implementation
Test Plan Docker image builds, the following commands are executing successfully:
Diff Detail
Event Timelinebartek held this revision as a draft. Herald added subscribers: atul, ashoat. · View Herald TranscriptNov 18 2022, 7:55 AM2022-11-18 07:55:19 (UTC-8) Harbormaster completed remote builds in B13556: Diff 18575.Nov 18 2022, 8:08 AM2022-11-18 08:08:51 (UTC-8) bartek retitled this revision from [services] Move current implementation to cpp directory to [services][blob] Move current implementation to cpp directory.Nov 18 2022, 10:46 AM2022-11-18 10:46:32 (UTC-8) Comment Actions I'd call this old instead of cpp maybe, so it's clear it's not actively-used C++ code Comment Actions
Good idea! This revision is now accepted and ready to land.Nov 22 2022, 5:50 AM2022-11-22 05:50:36 (UTC-8) Harbormaster completed remote builds in B13717: Diff 18797.Nov 23 2022, 11:50 PM2022-11-23 23:50:19 (UTC-8) Closed by commit rCOMM09897d7efea4: [services][blob] Move current implementation to cpp directory (authored by bartek). · Explain WhyNov 29 2022, 5:15 AM2022-11-29 05:15:28 (UTC-8) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 18932 |