Page MenuHomePhabricator

[services][blob] Move current implementation to cpp directory
ClosedPublic

Authored by bartek on Nov 18 2022, 7:55 AM.
Tags
None
Referenced Files
F3529523: D5675.diff
Tue, Dec 24, 7:27 PM
Unknown Object (File)
Fri, Dec 20, 7:13 PM
Unknown Object (File)
Sun, Dec 15, 5:50 PM
Unknown Object (File)
Sun, Dec 15, 5:50 PM
Unknown Object (File)
Sun, Dec 15, 5:49 PM
Unknown Object (File)
Sun, Dec 15, 5:49 PM
Unknown Object (File)
Sun, Dec 15, 5:29 PM
Unknown Object (File)
Oct 31 2024, 4:23 AM
Subscribers

Details

Summary

Until the Rust implementation is complete, the current C++ implementation
can live next to it.

  • Moved the C++ Blob Service code to the services/blob/cpp directory
  • Adjusted Dockerfile and CMakeLists.txt to use the new location
Test Plan

Docker image builds, the following commands are executing successfully:

  • yarn run-blob-service
  • yarn run-integration-tests blob

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Nov 18 2022, 9:16 AM
bartek added a reviewer: marcin.
bartek retitled this revision from [services] Move current implementation to cpp directory to [services][blob] Move current implementation to cpp directory.Nov 18 2022, 10:46 AM

I'd call this old instead of cpp maybe, so it's clear it's not actively-used C++ code

I'd call this old instead of cpp maybe, so it's clear it's not actively-used C++ code

Good idea!

This revision is now accepted and ready to land.Nov 22 2022, 5:50 AM

Rename cpp directory to old