Page MenuHomePhabricator
Differential D5707

Move ThreadDraftUpdater component to lib
ClosedPublic
Actions

Authored by marcin on Nov 23 2022, 4:29 AM.
Tags
None
Referenced Files
F3361063: D5707.id18751.diff
Sun, Nov 24, 3:07 PM
F3361015: D5707.id18826.diff
Sun, Nov 24, 2:58 PM
F3360514: D5707.diff
Sun, Nov 24, 1:01 PM
Unknown Object (File)
Tue, Nov 19, 2:23 PM
Unknown Object (File)
Tue, Nov 19, 2:23 PM
Unknown Object (File)
Tue, Nov 19, 2:23 PM
Unknown Object (File)
Tue, Nov 19, 2:23 PM
Unknown Object (File)
Tue, Nov 19, 2:21 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
tomek
ashoat
Commits
rCOMM7bb74f07807f: Move ThreadDraftUpdater component to lib
Summary

This differential moves ThreadDraftUpdater component to lib, so that it can be used on web app as well.

Test Plan

Draft moving functionality should remain on native. Open web app and native app on the same clien. Start typing message on the sidebar on native, then create the same sidebar on web. Draft should still be visible on native.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Nov 23 2022, 4:29 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 23 2022, 4:29 AM
marcin updated this revision to Diff 18751.Nov 23 2022, 4:31 AM

Rebase to update commit message

marcin added a child revision: D5696: Implement drafts persistence on web.Nov 23 2022, 4:34 AM
marcin added a parent revision: D5650: Remove CoreData and CoreDataProvider and use draftStore instead.
Harbormaster completed remote builds in B13684: Diff 18750.Nov 23 2022, 4:43 AM
Harbormaster completed remote builds in B13685: Diff 18751.
marcin requested review of this revision.Nov 23 2022, 4:44 AM
marcin added a reviewer: tomek.Nov 23 2022, 5:07 AM
ashoat accepted this revision.Nov 23 2022, 7:22 AM
This revision is now accepted and ready to land.Nov 23 2022, 7:22 AM
tomek accepted this revision.Nov 23 2022, 7:58 AM
marcin updated this revision to Diff 18826.Nov 25 2022, 1:12 AM

Rebase before landing

Harbormaster completed remote builds in B13743: Diff 18826.Nov 25 2022, 1:25 AM
Closed by commit rCOMM7bb74f07807f: Move ThreadDraftUpdater component to lib (authored by marcin). · Explain WhyNov 25 2022, 2:33 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM7bb74f07807f: Move ThreadDraftUpdater component to lib.

Revision Contents
Changeset List

PathSize
lib/
components/
native/
chat/
11 lines
native/
chat/
2 lines

Diff 18750

View Options

lib/components/thread-draft-updater.react.js

Loading...
View Options

native/chat/chat.react.js

Loading...
View Options

native/chat/thread-draft-updater.react.js

Loading...