Page MenuHomePhabricator
Differential D5716

[services][blob] Use chrono::DateTime for timestamps
ClosedPublic
Actions

Authored by bartek on Nov 24 2022, 1:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 3:03 PM
Unknown Object (File)
Fri, Dec 20, 2:49 PM
Unknown Object (File)
Fri, Dec 20, 11:13 AM
Unknown Object (File)
Sun, Dec 15, 5:50 PM
Unknown Object (File)
Sun, Dec 15, 5:50 PM
Unknown Object (File)
Sun, Dec 15, 5:50 PM
Unknown Object (File)
Sun, Dec 15, 5:49 PM
Unknown Object (File)
Sun, Dec 15, 5:29 PM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
varun
ashoat
tomek
marcin
• jon
Commits
rCOMM9c4868c181bd: [services][blob] Use chrono::DateTime for timestamps
Summary

Resolves ENG-2309

This allows me to use rfc3339 in the next diff.

Adding @ashoat as this adds a new dependency (however the same is used in identity service)

Depends on D5682

Test Plan

Cargo builds

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Nov 24 2022, 1:27 AM
bartek held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptNov 24 2022, 1:27 AM
Herald added a subscriber: atul. · View Herald Transcript
bartek published this revision for review.Nov 24 2022, 1:28 AM
bartek added a child revision: D5693: [services][blob] Add methods to manage the blob table.
Harbormaster completed remote builds in B13725: Diff 18805.Nov 24 2022, 1:40 AM
tomek accepted this revision.Nov 24 2022, 5:07 AM
tomek added 1 blocking reviewer(s): ashoat.
tomek added inline comments.
services/blob/Cargo.toml
16

We shouldn't specify the patch version. Even now the most recent one is 0.4.23.

The same applies to other libraries.

ashoat accepted this revision.Nov 24 2022, 9:36 AM
varun accepted this revision.Nov 28 2022, 10:56 PM
This revision is now accepted and ready to land.Nov 28 2022, 10:56 PM
bartek updated this revision to Diff 18908.Nov 29 2022, 2:22 AM

Removed specifying dependency patch version for chrono.

Harbormaster completed remote builds in B13815: Diff 18908.Nov 29 2022, 2:35 AM
Closed by commit rCOMM9c4868c181bd: [services][blob] Use chrono::DateTime for timestamps (authored by bartek). · Explain WhyNov 29 2022, 5:15 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM9c4868c181bd: [services][blob] Use chrono::DateTime for timestamps.

Revision Contents
Changeset List

PathSize
services/
blob/
1 line
src/
3 lines

Diff 18805

View Options

services/blob/Cargo.lock

Loading...
View Options

services/blob/Cargo.toml

Loading...
View Options

services/blob/src/database.rs

Loading...