Details
Details
- Create a blob using e.g. the C++ blob service (or in any other way)
- Get the blob data with the Rust implementation
- If the data is small, modify chunk_size to some small value to test if multiple parts are returned as expected
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
One question inline
| services/blob/src/service.rs | ||
|---|---|---|
| 90 | Do you think we should do some validation on the value returned by content_length before we take the absolute value? | |
| services/blob/src/service.rs | ||
|---|---|---|
| 90 | Good catch, I can do sth like this: let file_size: u64 = object_metadata.content_length().try_into().map_err(|err| { error!("Invalid content length: {:?}", err); Status::aborted("server error") })?; | |