Page MenuHomePhabricator

[web] Calling utility functions in Overlay component.
ClosedPublic

Authored by przemek on Nov 24 2022, 7:27 AM.
Tags
None
Referenced Files
F3382830: D5720.id18842.diff
Thu, Nov 28, 12:09 PM
Unknown Object (File)
Sun, Nov 24, 9:45 PM
Unknown Object (File)
Sun, Nov 24, 7:36 PM
Unknown Object (File)
Sun, Nov 24, 6:08 PM
Unknown Object (File)
Fri, Nov 22, 8:00 AM
Unknown Object (File)
Fri, Nov 22, 8:00 AM
Unknown Object (File)
Fri, Nov 22, 8:00 AM
Unknown Object (File)
Fri, Nov 22, 7:54 AM

Details

Summary

The component now takes all the data needed via props and calls utility functions wrapped in useMemo.
Moved type exports to utility file in previous diff.

Test Plan

Component not rendered yet, but tested visibility.
App builds.

Diff Detail

Repository
rCOMM Comm
Branch
feat/mention
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek requested changes to this revision.Nov 25 2022, 3:19 AM
tomek added inline comments.
web/chat/mention-suggestion-tooltip.react.js
24

This isn't too useful for the component. It's hard to deduce what's inside of it without checking all the usages. It's more maintainable to simply pass the strings instead.

This revision now requires changes to proceed.Nov 25 2022, 3:19 AM
przemek added inline comments.
web/chat/mention-suggestion-tooltip.react.js
24

Changed it so that component receives 3 strings instead.

przemek marked an inline comment as done.

Fixed props.

tomek added inline comments.
web/chat/mention-suggestion-tooltip.react.js
24

How about going to step further and using TypeaheadMatchedStrings from the next diff?

This revision is now accepted and ready to land.Nov 25 2022, 9:05 AM