Page MenuHomePhabricator

[native] Introduce TextMessageMarkdownContext
ClosedPublic

Authored by ashoat on Nov 29 2022, 7:19 AM.
Tags
None
Referenced Files
F3353392: D5754.diff
Sat, Nov 23, 9:42 AM
Unknown Object (File)
Mon, Nov 4, 8:21 AM
Unknown Object (File)
Mon, Nov 4, 3:09 AM
Unknown Object (File)
Sun, Oct 27, 2:16 PM
Unknown Object (File)
Oct 16 2024, 10:38 PM
Unknown Object (File)
Oct 14 2024, 10:55 PM
Unknown Object (File)
Sep 27 2024, 7:22 PM
Unknown Object (File)
Sep 27 2024, 7:22 PM
Subscribers

Details

Summary

We need the AST from inside InnerTextMessage in order to determine whether the Markdown has any "pressables" (link or spoiler for now, but @mention in the future).

Test Plan

Flow, tested with following diff

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat added inline comments.
native/chat/text-message-markdown-context.js
17 ↗(On Diff #18959)

Prettier seems to force this long line unfortunately

Setting up the parser seems consistent with the existing markdown code - I assume TextMessageMarkdownContext will replace MessageContext from D5515? I.e. MarkdownSpoiler will rebase these changes and then retrieve the messageKey from this instead

This revision is now accepted and ready to land.Nov 30 2022, 9:18 AM