Page MenuHomePhabricator

[keyserver] add endpoint to acknowledge policy
ClosedPublic

Authored by kamil on Dec 6 2022, 5:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 2:37 PM
Unknown Object (File)
Wed, Nov 6, 7:08 PM
Unknown Object (File)
Wed, Nov 6, 7:08 PM
Unknown Object (File)
Wed, Nov 6, 6:20 AM
Unknown Object (File)
Mon, Oct 28, 7:56 AM
Unknown Object (File)
Oct 3 2024, 1:17 AM
Unknown Object (File)
Oct 1 2024, 6:49 AM
Unknown Object (File)
Sep 28 2024, 2:27 PM
Subscribers

Details

Summary

Endpoint which allows acknowledging policy, which is specified in request.

Preferring HTTP connection because in the future we maybe will want to close socket connection when policy is not accepted.

Context in ENG-2352

Test Plan
  1. hit endpoint with corrent and incorrect policy to check if validator works
  2. check if value is properly updated in policy_acknowledgments table

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Dec 6 2022, 6:55 AM
tomek added inline comments.
lib/types/endpoints.js
87

It seems like we have sessionChangingEndpoints - if POLICY_ACKNOWLEDGMENT might change session, maybe we should put it there (depends on things like setting cookie, etc.). If we're expecting closing a socket we can also consider making it http only endpoint.

This revision is now accepted and ready to land.Dec 6 2022, 9:16 AM

make policy_acknowledgment session changing endpoint

lib/types/endpoints.js
87

Good point, added POLICY_ACKNOWLEDGMENT to sessionChangingEndpoints which made this also HTTPOnlyEndpoint