Update the Rust Tonic crate to use the 0.8 version across all services.
To fix the gRPC generation error the prost should be upgraded as well.
The installation of the protoc compiler was added to the identity service Dockerfile.
Details
Details
The services are successfully built.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- tonic-bump
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
looks like the identity image will need to be updated to install protoc in PATH for it to be found.
Comment Actions
Making this a Draft until the Identity service failing fix solution decision comes in ENG-1949
Comment Actions
Eventually, I would like to get the docker images to also use the same protoc as the rest of the project, ubuntu has been on 3.12 for the past ~4 years.
But that's future work, this looks fine.
| services/identity/Dockerfile | ||
|---|---|---|
| 3 ↗ | (On Diff #19250) | Why do we have to add this? Curious why things worked without installing protobuf-compiler when we were on tonic 0.6 |
| services/identity/Dockerfile | ||
|---|---|---|
| 3 ↗ | (On Diff #19250) |
It's related to the recent prost version. Since 0.11 it requires to protoc to be available. |
Comment Actions
We are removing the cache from the apt-get update because we don't need it anymore, but it took up a lot of disk space.
| services/identity/Dockerfile | ||
|---|---|---|
| 4 ↗ | (On Diff #19250) | Can you indent this line so it's clear that it's associated with the above line? |
Comment Actions
Adding of indent.
| services/identity/Dockerfile | ||
|---|---|---|
| 4 ↗ | (On Diff #19250) |
Sure! Done. |