Page MenuHomePhabricator
Differential D5821

[keyserver] add endpoint to acknowledge policy
ClosedPublic
Actions

Authored by kamil on Dec 6 2022, 5:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 8:30 PM
Unknown Object (File)
Sun, Dec 15, 8:30 PM
Unknown Object (File)
Sun, Dec 15, 8:30 PM
Unknown Object (File)
Sun, Dec 15, 8:29 PM
Unknown Object (File)
Sun, Dec 15, 8:20 PM
Unknown Object (File)
Thu, Dec 5, 9:44 AM
Unknown Object (File)
Nov 7 2024, 2:37 PM
Unknown Object (File)
Nov 6 2024, 7:08 PM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
Commits
rCOMMe33199bde9f8: [keyserver] add endpoint to acknowledge policy
Summary

Endpoint which allows acknowledging policy, which is specified in request.

Preferring HTTP connection because in the future we maybe will want to close socket connection when policy is not accepted.

Context in ENG-2352

Test Plan
  1. hit endpoint with corrent and incorrect policy to check if validator works
  2. check if value is properly updated in policy_acknowledgments table

Diff Detail

Repository
rCOMM Comm
Branch
policy-stuff-5
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Dec 6 2022, 5:51 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptDec 6 2022, 5:51 AM
kamil added a parent revision: D5820: Revert "[keyserver] update acknowledgment table in login was performed from proper source".Dec 6 2022, 5:52 AM
kamil edited the summary of this revision. (Show Details)
kamil edited the summary of this revision. (Show Details)Dec 6 2022, 5:55 AM
Harbormaster completed remote builds in B14001: Diff 19174.Dec 6 2022, 6:01 AM
kamil added a child revision: D5822: [keyserver] add viewer acknowledgment fetcher.Dec 6 2022, 6:03 AM
kamil published this revision for review.Dec 6 2022, 6:55 AM
tomek accepted this revision.Dec 6 2022, 9:16 AM
tomek added inline comments.
lib/types/endpoints.js
87 ↗(On Diff #19174)

It seems like we have sessionChangingEndpoints - if POLICY_ACKNOWLEDGMENT might change session, maybe we should put it there (depends on things like setting cookie, etc.). If we're expecting closing a socket we can also consider making it http only endpoint.

This revision is now accepted and ready to land.Dec 6 2022, 9:16 AM
kamil updated this revision to Diff 19310.Dec 13 2022, 4:41 AM

make policy_acknowledgment session changing endpoint

kamil added inline comments.Dec 13 2022, 4:43 AM
lib/types/endpoints.js
87 ↗(On Diff #19174)

Good point, added POLICY_ACKNOWLEDGMENT to sessionChangingEndpoints which made this also HTTPOnlyEndpoint

Harbormaster completed remote builds in B14110: Diff 19310.Dec 13 2022, 4:54 AM
Closed by commit rCOMMe33199bde9f8: [keyserver] add endpoint to acknowledge policy (authored by kamil). · Explain WhyDec 15 2022, 2:54 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMe33199bde9f8: [keyserver] add endpoint to acknowledge policy.

Revision Contents
Changeset List

PathSize
keyserver/
src/
2 lines
responders/
21 lines
lib/
types/
5 lines
1 line

Diff 19310

View Options

keyserver/src/endpoints.js

Loading...
View Options

keyserver/src/responders/user-responders.js

Loading...
View Options

lib/types/account-types.js

Loading...
View Options

lib/types/endpoints.js

Loading...