[services] Tunnelbroker - Remove `cryptopp` usage from the C++ codebase
ClosedPublic
Actions

Authored by • max on Dec 19 2022, 12:37 PM.

Details

Reviewers

• jon
bartek
tomek

Commits

rCOMM506641f4a271: [services] Tunnelbroker - Remove `cryptopp` usage from the C++ codebase

Summary

This diff removes deprecated C++ code related to the use of cryptopp library.
In D5947 we are switched to using the Rust function for the signed string verification and we don't need the cryptopp and related C++ code base anymore.

Removing cryptopp from the dependencies is in the following D5949.

Linear task: ENG-2492

Test Plan

The Tunnelbroker server application is successfully built.

Diff Detail

Repository

rCOMM Comm

Branch

remove-cryptopp-remove-from-cpp

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Dec 19 2022, 12:37 PM

• max held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptDec 19 2022, 12:37 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald Transcript

• max added a parent revision: D5947: [services] Tunnelbroker - Modify server handler to use Rust signature verification.Dec 19 2022, 12:38 PM

• max added a child revision: D5949: [services] Tunnelbroker - Remove `cryptopp` from dependencies.

Harbormaster failed remote builds in B14469: Diff 19724!Dec 19 2022, 1:04 PM

• max mentioned this in D5947: [services] Tunnelbroker - Modify server handler to use Rust signature verification.Dec 21 2022, 5:57 AM

• max edited the summary of this revision. (Show Details)Dec 21 2022, 6:01 AM

• max edited the test plan for this revision. (Show Details)

• max added a reviewer: bartek. • max added 1 blocking reviewer(s): • jon.

As we have trouble using Nix in the CI gate please ignore the Nix build fail for now.

rebase should fix CI gate

This revision is now accepted and ready to land.Dec 21 2022, 2:06 PM

• max added a reviewer: tomek.Dec 23 2022, 7:48 AM

This revision now requires review to proceed.Dec 23 2022, 7:48 AM

Adding @tomek for a final pass as this is a C++ part of the codebase.

Rebasing on master.

Harbormaster completed remote builds in B14715: Diff 20068.Dec 23 2022, 8:10 AM

Why is the verification moved outside the newSessionHandler?

This revision is now accepted and ready to land.Dec 27 2022, 4:00 AM

• max mentioned this in rCOMMbe572df58390: [services] Tunnelbroker - Modify server handler to use Rust signature….Dec 28 2022, 8:31 AM

In D5948#181364, @tomek wrote:

Why is the verification moved outside the newSessionHandler?

We are verifying now on the Rust side in D5947 and no need to call it from the C++ side anymore because we are using the Rust string verification function from D5945. We are returning an error in case the string verification failed and we can send it from the Rust now.