Page MenuHomePhabricator
Differential D5969

[native/rust_library] Adding CXX bridge names for C++ Identity service client functions
ClosedPublic
Actions

Authored by • max on Dec 21 2022, 4:54 AM.
Tags
None
Referenced Files
F2155684: D5969.id20020.diff
Sun, Jun 30, 10:12 PM
F2151673: D5969.id.diff
Sun, Jun 30, 1:11 PM
Unknown Object (File)
Sat, Jun 29, 9:36 PM
Unknown Object (File)
Sat, Jun 29, 7:40 AM
Unknown Object (File)
Sat, Jun 29, 12:01 AM
Unknown Object (File)
Fri, Jun 28, 7:10 PM
Unknown Object (File)
Fri, Jun 28, 12:24 PM
Unknown Object (File)
Wed, Jun 26, 10:35 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
varun
• jon
tomek
Commits
rCOMM85d153794a09: [native/rust_library] Adding CXX bridge names for C++ Identity service client…
Summary

This diff introduces adding the C++ names for the exposed Rust functions which will override the Rust function names to meet our C++ function names convention and make their usage in the C++ codebase clear.

Linear task: ENG-1333

Test Plan

Rust library and native app are successfully built.

Diff Detail

Repository
rCOMM Comm
Branch
restruct-native-rust-library-add-namespace
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• max created this revision.Dec 21 2022, 4:54 AM
• max held this revision as a draft.
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 21 2022, 4:54 AM
• max added a parent revision: D5968: [native/rust_library] Refactor Tonic client utility function names for Identity service.Dec 21 2022, 4:55 AM
Harbormaster failed remote builds in B14617: Diff 19937!Dec 21 2022, 4:59 AM
• max retitled this revision from [native/rust_library] Adding namespaces for C++ bridge for Identity service functions to [native/rust_library] Adding CXX bridge names for C++ Identity service client functions.Dec 21 2022, 5:15 AM
• max edited the summary of this revision. (Show Details)
• max edited the test plan for this revision. (Show Details)
• max added reviewers: varun, • jon.
• max updated this revision to Diff 19940.Dec 21 2022, 5:16 AM

Removing global namespace.

Harbormaster failed remote builds in B14620: Diff 19940!Dec 21 2022, 5:20 AM
• max updated this revision to Diff 19943.Dec 21 2022, 5:35 AM

Fixing build error.

Harbormaster completed remote builds in B14622: Diff 19943.Dec 21 2022, 5:46 AM
• max published this revision for review.Dec 21 2022, 6:04 AM
varun accepted this revision.Dec 21 2022, 1:37 PM
This revision is now accepted and ready to land.Dec 21 2022, 1:37 PM
• max updated this revision to Diff 20020.Dec 22 2022, 6:23 AM

Rebasing and merging on master changes.

Harbormaster completed remote builds in B14681: Diff 20020.Dec 22 2022, 6:37 AM
• max added a child revision: D5997: [native/rust_library] Adding of the Tunnelbroker Tonic client initialization.Dec 22 2022, 6:57 AM
• max added a reviewer: tomek.Dec 23 2022, 9:15 AM
This revision now requires review to proceed.Dec 23 2022, 9:15 AM
• max added a comment.Dec 23 2022, 9:16 AM

Adding @tomek for a final pass as this change touches JSI, and C++ native side names.

• jon accepted this revision.Dec 23 2022, 2:34 PM
tomek accepted this revision.Dec 27 2022, 4:13 AM
tomek added inline comments.
native/native_rust_library/src/lib.rs
1–2 ↗(On Diff #20020)

Why this change is included in this diff?

This revision is now accepted and ready to land.Dec 27 2022, 4:13 AM
• max updated this revision to Diff 20247.Dec 28 2022, 10:19 AM

Removing moving of uses in the header.

• max marked an inline comment as done.Dec 28 2022, 10:21 AM
• max added inline comments.
native/native_rust_library/src/lib.rs
1–2 ↗(On Diff #20020)

Why this change is included in this diff?

This is about organizing uses in one place, fixed by the linter, but it's better to move it into a separate diff. Thanks.

Harbormaster completed remote builds in B14847: Diff 20247.Dec 28 2022, 10:32 AM
Closed by commit rCOMM85d153794a09: [native/rust_library] Adding CXX bridge names for C++ Identity service client… (authored by • max). · Explain WhyDec 28 2022, 10:35 AM
This revision was automatically updated to reflect the committed changes.
• max marked an inline comment as done.
• max added a commit: rCOMM85d153794a09: [native/rust_library] Adding CXX bridge names for C++ Identity service client….

Revision Contents
Changeset List

PathSize
native/
native_rust_library/
src/
20 lines

Diff 19937

View Options

native/native_rust_library/src/lib.rs

Loading...