Page MenuHomePhabricator
Differential D5944

[services] Tunnelbroker - Adding of the `base64` crate to dependencies
ClosedPublic
Actions

Authored by • max on Dec 19 2022, 12:33 PM.
Tags
None
Referenced Files
F3512111: D5944.diff
Sat, Dec 21, 6:18 PM
Unknown Object (File)
Wed, Dec 18, 6:16 PM
Unknown Object (File)
Wed, Dec 18, 6:16 PM
Unknown Object (File)
Wed, Dec 18, 6:16 PM
Unknown Object (File)
Wed, Dec 18, 6:16 PM
Unknown Object (File)
Wed, Dec 18, 6:16 PM
Unknown Object (File)
Wed, Dec 18, 6:16 PM
Unknown Object (File)
Wed, Dec 18, 10:59 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• jon
bartek
ashoat
Commits
rCOMM3c34a2e014ba: [services] Tunnelbroker - Adding of the `base64` crate to dependencies
Summary

This diff adds a base64 crate to the Cargo Tunnelbroker dependencies.
base64 functions will be used in the following D5945 in a verify_signed_string function.

Linear task: ENG-2492

Test Plan

As this diff is a part of the stack this diff can be tested on the end of the stack at D5947.
To test it:

  • Patch to the D5947
  • Run the integration tests in D5931 using the cargo t --test tunnelbroker_integration_test command.

The expected result is passing the integration test (signing and verifying the string are successful and the new session creation test will pass).

Diff Detail

Repository
rCOMM Comm
Branch
remove-cryptopp-add-base64-crate
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• max created this revision.Dec 19 2022, 12:33 PM
• max held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptDec 19 2022, 12:33 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald Transcript
• max added a child revision: D5945: [services] Tunnelbroker - Adding signed string verification function.Dec 19 2022, 12:35 PM
Harbormaster completed remote builds in B14465: Diff 19720.Dec 19 2022, 1:04 PM
• max updated this revision to Diff 19780.Dec 20 2022, 7:12 AM

Rebasing on master changes.

Harbormaster failed remote builds in B14523: Diff 19780!Dec 20 2022, 7:12 AM
• max updated this revision to Diff 19892.Dec 20 2022, 2:11 PM

Rebasing on a master changes.

Harbormaster failed remote builds in B14586: Diff 19892!Dec 20 2022, 2:12 PM
• max updated this revision to Diff 19932.Dec 21 2022, 3:24 AM

Rebasing on master.

Harbormaster failed remote builds in B14612: Diff 19932!Dec 21 2022, 3:25 AM
• max edited the summary of this revision. (Show Details)Dec 21 2022, 5:41 AM
• max edited the test plan for this revision. (Show Details)
• max added a reviewer: bartek. • max added 1 blocking reviewer(s): • jon.
• max published this revision for review.Dec 21 2022, 6:05 AM

As we have trouble using Nix in the CI gate please ignore the Nix build fail for now.

• jon accepted this revision.Dec 21 2022, 2:00 PM

Gate should be fixed if you rebase on master

This revision is now accepted and ready to land.Dec 21 2022, 2:00 PM
• max updated this revision to Diff 20066.Dec 23 2022, 7:52 AM

Rebasing on master.

Harbormaster completed remote builds in B14713: Diff 20066.Dec 23 2022, 8:06 AM
• max added a reviewer: ashoat.Dec 23 2022, 8:06 AM
This revision now requires review to proceed.Dec 23 2022, 8:06 AM
• max added a comment.Dec 23 2022, 8:07 AM

Adding @ashoat for a final pass because this diff touches dependencies.

ashoat accepted this revision.Dec 23 2022, 10:24 AM
This revision is now accepted and ready to land.Dec 23 2022, 10:24 AM
Closed by commit rCOMM3c34a2e014ba: [services] Tunnelbroker - Adding of the `base64` crate to dependencies (authored by • max). · Explain WhyDec 27 2022, 6:15 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMM3c34a2e014ba: [services] Tunnelbroker - Adding of the `base64` crate to dependencies.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
1 line

Diff 20066

View Options

services/tunnelbroker/Cargo.lock

Loading...
View Options

services/tunnelbroker/Cargo.toml

Loading...