Details

Reviewers

atul
tomek
ashoat

Commits

rCOMMe14ebc976289: Do not prompt for password when deleting thread

Summary

This differential prevents native UI from prompting for password when deleting thread for any account

Test Plan

Test plan is the same as for previous differential in the stack, but now we expect password prompt not to show (so do not have to provide any password)

Diff Detail

Repository

rCOMM Comm

Branch

marcin/eng-2541

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Dec 29 2022, 6:54 AM

Herald added a subscriber: ashoat. · View Herald TranscriptDec 29 2022, 6:54 AM

marcin published this revision for review.Dec 29 2022, 6:55 AM

marcin added a parent revision: D6102: Ignore password when deleting thread on the server side.

Harbormaster failed remote builds in B14923: Diff 20340!Dec 29 2022, 6:59 AM

tomek requested changes to this revision.Dec 29 2022, 7:11 AM

tomek added inline comments.

native/chat/settings/delete-thread.react.js
62 ↗	(On Diff #20340)	Can we delete this parameter?
67 ↗	(On Diff #20340)	It seems like we can delete the state completely

This revision now requires changes to proceed.Dec 29 2022, 7:11 AM

Remove all password references from delete-thread compoment

Harbormaster failed remote builds in B14924: Diff 20341!Dec 29 2022, 7:24 AM

tomek requested changes to this revision.Dec 29 2022, 7:33 AM

tomek added inline comments.

native/chat/settings/delete-thread.react.js
120–121	We can probably merge these now - a button is always enabled
171–172	We shouldn't mention password at all. It seems like we can always go to the default branch.

This revision now requires changes to proceed.Dec 29 2022, 7:33 AM

Update styles and text displayed to the user

Adding @ashoat as a reviewer since now it involves changes in text displayed to the user.

native/chat/settings/delete-thread.react.js
171–172	Not necessarily - when user does not have appropriate permissions invalid_credentials error is thrown. We should update if statement and alert message.

Harbormaster failed remote builds in B14925: Diff 20342!Dec 29 2022, 7:48 AM

tomek accepted this revision.Dec 29 2022, 7:48 AM

tomek added inline comments.

native/chat/settings/delete-thread.react.js
180 ↗	(On Diff #20342)	As this is the only delete button class the name can be shortened

This revision is now accepted and ready to land.Dec 29 2022, 7:48 AM

Simplify delete thread button CSS name

Harbormaster failed remote builds in B14927: Diff 20344!Dec 29 2022, 8:05 AM

marcin added a child revision: D6104: Conditionally hide possibility to change password for SIWE accounts.Dec 29 2022, 8:12 AM

Text seems okay. Given this is a visual diff, would be good to share a screenshot of the updated DeleteThread screen

Rebase master

Harbormaster completed remote builds in B14938: Diff 20356.Dec 29 2022, 9:02 AM

In D6103#182993, @ashoat wrote:

Text seems okay. Given this is a visual diff, would be good to share a screenshot of the updated DeleteThread screen

New Delete Thread Screen