Page MenuHomePhabricator
Differential D6118

[keyserver/lib] introuce localID field to sendReactionMessage action and reactionMessageCreationResponder
ClosedPublic
Actions

Authored by ginsu on Dec 30 2022, 3:41 PM.
Tags
None
Referenced Files
F3525708: D6118.id20713.diff
Mon, Dec 23, 6:16 PM
F3525701: D6118.id20456.diff
Mon, Dec 23, 6:11 PM
F3525537: D6118.id20722.diff
Mon, Dec 23, 5:33 PM
F3523959: D6118.diff
Mon, Dec 23, 10:46 AM
Unknown Object (File)
Sat, Nov 30, 10:06 AM
Unknown Object (File)
Thu, Nov 28, 11:19 AM
Unknown Object (File)
Thu, Nov 28, 11:19 AM
Unknown Object (File)
Nov 21 2024, 6:50 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
tomek
Commits
rCOMM6e4bd6322ea4: [keyserver/lib] introuce localID field to sendReactionMessage action and…
Summary

introuce localID field to sendReactionMessage action and reactionMessageCreationResponder. We need to do this to pass the localID to the server when creating new reaction messages

Depends on D6117
Linear Task: ENG-2519

Test Plan

flow this will be tested in subsequent diffs

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Dec 30 2022, 3:41 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 30 2022, 3:41 PM
ginsu edited the summary of this revision. (Show Details)Dec 30 2022, 3:43 PM
ginsu added reviewers: atul, tomek.
ginsu added a parent revision: D6117: [lib] add localID field to reaction message type.
ginsu added a child revision: D6119: [web] introduce localID field to useOnClickReact hook.Dec 30 2022, 3:52 PM
Harbormaster completed remote builds in B14987: Diff 20456.Dec 30 2022, 3:54 PM
ginsu requested review of this revision.Dec 30 2022, 3:54 PM
tomek accepted this revision.Jan 2 2023, 5:10 AM
This revision is now accepted and ready to land.Jan 2 2023, 5:10 AM
ginsu updated this revision to Diff 20713.Jan 9 2023, 9:39 AM

rebase before landing

Harbormaster completed remote builds in B15198: Diff 20713.Jan 9 2023, 9:53 AM
Closed by commit rCOMM6e4bd6322ea4: [keyserver/lib] introuce localID field to sendReactionMessage action and… (authored by ginsu). · Explain WhyJan 9 2023, 10:05 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM6e4bd6322ea4: [keyserver/lib] introuce localID field to sendReactionMessage action and….
ashoat added inline comments.Jan 11 2023, 1:44 PM
keyserver/src/responders/message-responders.js
195 ↗(On Diff #20722)

I think this is where you broke support for old clients. Any existing client won't include this, and you're requiring it here

ashoat added a comment.Jan 11 2023, 1:45 PM

Can we revert this diff please? New release won't solve the problem for old clients

ginsu added inline comments.Jan 11 2023, 1:48 PM
keyserver/src/responders/message-responders.js
195 ↗(On Diff #20722)

Okay I got it now, thank you for clarifying. Will work on reverting diff rn

ginsu added a reverting change: D6244: Revert "[keyserver/lib] introuce localID field to sendReactionMessage action and reactionMessageCreationResponder".Jan 11 2023, 3:39 PM
ginsu added a reverting change: rCOMM24b904db30f8: Revert "[keyserver/lib] introuce localID field to sendReactionMessage action….Jan 11 2023, 7:51 PM

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
4 lines
lib/
actions/
1 line

Diff 20456

View Options

keyserver/src/responders/message-responders.js

Loading...
View Options

lib/actions/message-actions.js

Loading...