We have to make sure our types are in sync with the code. In this diff we should update redux-types by setting a payload type of started action - it would be great if Flow could catch this.

web/chat/reaction-message-utils.js
33	I don't think it is a good idea to use invariants in a lot of places. Sometimes they are necessary, but usually can be avoided. In this case, there's no point in having an invariant here. We can safely execute the hook without the id set. The id becomes necessary when we want to send a message, so the invariant may be added inside `useCallback`.

This revision now requires changes to proceed.Jan 2 2023, 6:04 AM

address feedback

In this diff we should update redux-types by setting a payload type of started action

D5769 should address this, but please let me know if I missed anything

Harbormaster completed remote builds in B15061: Diff 20548.Jan 3 2023, 2:51 PM

In D6121#184564, @ginsu wrote:

In this diff we should update redux-types by setting a payload type of started action

D5769 should address this, but please let me know if I missed anything

That diff looks ok now, thanks!

This revision is now accepted and ready to land.Jan 5 2023, 4:37 AM

rebase before landing

Harbormaster completed remote builds in B15201: Diff 20716.Jan 9 2023, 9:57 AM

Closed by commit rCOMMb96d61032e06: [web] add starting payload to send reaction message dispatch action promise (authored by ginsu). · Explain WhyJan 9 2023, 10:05 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMb96d61032e06: [web] add starting payload to send reaction message dispatch action promise.