Details

Reviewers

ashoat
tomek

Commits

rCOMMc13c35676480: [keyserver] Store `SIWESocialProof` in `social_proof` column of `cookies` table

Summary

Stringify the SIWESocialProof object and store in the social_proof column of the cookies table.

Depends on D6135

Test Plan

public_key and social_proof columns populated as expected:

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Dec 31 2022, 1:41 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 31 2022, 1:45 PM

Harbormaster failed remote builds in B15011: Diff 20488!

fix

atul edited the summary of this revision. (Show Details)Jan 1 2023, 12:19 AM

atul edited the test plan for this revision. (Show Details)

atul retitled this revision from [DRAFT] Store `SIWESocialProof` in `social_proof` column of `cookies` table to [keyserver] Store `SIWESocialProof` in `social_proof` column of `cookies` table.

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 1 2023, 12:22 AM

Harbormaster failed remote builds in B15014: Diff 20491!

flow

Harbormaster completed remote builds in B15015: Diff 20492.Jan 1 2023, 12:35 AM

atul requested review of this revision.Jan 1 2023, 12:35 AM

Please address before landing

lib/types/siwe-types.js
30–31 ↗	(On Diff #20492)	Can these be read-only?

This revision is now accepted and ready to land.Jan 2 2023, 4:02 AM

atul added inline comments.Jan 3 2023, 11:38 PM

lib/types/siwe-types.js
30–31 ↗	(On Diff #20492)	Yeah totally

rebase

address feedback

Harbormaster completed remote builds in B15067: Diff 20558.Jan 4 2023, 12:11 AM

Harbormaster completed remote builds in B15068: Diff 20559.

rebase before landing

This revision was landed with ongoing or failed builds.Jan 5 2023, 7:29 AM

Closed by commit rCOMMc13c35676480: [keyserver] Store `SIWESocialProof` in `social_proof` column of `cookies` table. · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMc13c35676480: [keyserver] Store `SIWESocialProof` in `social_proof` column of `cookies` table.

Harbormaster completed remote builds in B15097: Diff 20590.Jan 5 2023, 7:40 AM

[keyserver] Store `SIWESocialProof` in `social_proof` column of `cookies` table
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 20558

keyserver/src/creators/account-creator.js

keyserver/src/responders/user-responders.js

keyserver/src/session/cookies.js

lib/types/siwe-types.js

[keyserver] Store `SIWESocialProof` in `social_proof` column of `cookies` tableClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 20558

keyserver/src/creators/account-creator.js

keyserver/src/responders/user-responders.js

keyserver/src/session/cookies.js

lib/types/siwe-types.js

[keyserver] Store `SIWESocialProof` in `social_proof` column of `cookies` table
ClosedPublic
Actions

Revision Contents
Changeset List