Page MenuHomePhabricator
Differential D6195

[web] Make long thread names end with ellipsis in subchannels modal
ClosedPublic
Actions

Authored by inka on Jan 9 2023, 3:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 6, 8:05 AM
Unknown Object (File)
Fri, Dec 6, 7:38 AM
Unknown Object (File)
Fri, Nov 22, 4:34 AM
Unknown Object (File)
Fri, Nov 22, 4:34 AM
Unknown Object (File)
Fri, Nov 22, 4:34 AM
Unknown Object (File)
Fri, Nov 22, 4:34 AM
Unknown Object (File)
Fri, Nov 22, 4:33 AM
Unknown Object (File)
Nov 3 2024, 6:13 PM
View All 89 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• przemek
michal
bartek
Commits
rCOMMc2b967f033a2: [web] Make long thread names end with ellipsis in subchannels modal
Summary

Issue: https://linear.app/comm/issue/ENG-2638/ellipsis-in-subchannels-modal-on-web
before:

Screenshot 2023-01-09 at 12.08.57.png (1×676 px, 63 KB)

now:

Screenshot 2023-01-09 at 12.09.09.png (1×670 px, 62 KB)

Test Plan

Check the subchannels modals long titles end with ellipsis, check that the style change did not affect its other usage - the message preview.

Diff Detail

Repository
rCOMM Comm
Branch
inka/modal_ellipsis
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Jan 9 2023, 3:03 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 9 2023, 3:03 AM
inka edited the summary of this revision. (Show Details)Jan 9 2023, 3:04 AM
inka attached a referenced file: F322309: Screenshot 2023-01-09 at 11.56.33.png. (Show Details)
inka attached a referenced file: F322307: Screenshot 2023-01-09 at 11.56.03.png. (Show Details)
inka updated this revision to Diff 20665.Jan 9 2023, 3:09 AM

Fix short names

inka edited the summary of this revision. (Show Details)Jan 9 2023, 3:10 AM
Harbormaster completed remote builds in B15153: Diff 20664.Jan 9 2023, 3:14 AM
Harbormaster completed remote builds in B15154: Diff 20665.Jan 9 2023, 3:24 AM
inka requested review of this revision.Jan 9 2023, 3:24 AM
inka attached a referenced file: F322335: Screenshot 2023-01-09 at 12.08.57.png. (Show Details)Jan 9 2023, 4:12 AM
inka attached a referenced file: F322336: Screenshot 2023-01-09 at 12.09.09.png. (Show Details)
bartek accepted this revision.Jan 9 2023, 5:12 AM
This revision is now accepted and ready to land.Jan 9 2023, 5:12 AM
inka added a comment.Jan 9 2023, 6:45 AM

Going to land this now since it was decided on one of the last few meetings that for trivial diffs we don't need to add a final reviewer.
Related issue: https://linear.app/comm/issue/ENG-2648/get-rid-of-formal-blocking-reviewers-requirement

Closed by commit rCOMMc2b967f033a2: [web] Make long thread names end with ellipsis in subchannels modal (authored by • InkaSokolowska). · Explain WhyJan 9 2023, 6:46 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMMc2b967f033a2: [web] Make long thread names end with ellipsis in subchannels modal.

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
subchannels/
1 line

Diff 20665

View Options

web/modals/threads/subchannels/subchannels-modal.css

Loading...