Paths

Table of Contentst

[desktop] Type bridge object between desktop and web
ClosedPublic
Actions

Authored by michal on Jan 5 2023, 4:53 AM.

Details

Reviewers

tomek
ginsu
inka
ashoat

Commits

rCOMM21395b9f8ad8: [desktop] Type bridge object between desktop and web

Summary

ENG-2219
Previously this bridge object (through which we send messages between electron and web app) was typed only on web. This diff moves the types to lib and uses them on desktop to keep everything in sync.

Test Plan

Run flow in desktop and web.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Jan 5 2023, 4:53 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptJan 5 2023, 4:53 AM

michal added a parent revision: D6174: [desktop] Enable flow in the desktop workspace.Jan 5 2023, 4:53 AM

michal added a child revision: D6176: [desktop] Flow type electron.Jan 5 2023, 5:02 AM

Harbormaster completed remote builds in B15118: Diff 20613.Jan 5 2023, 5:05 AM

michal requested review of this revision.Jan 5 2023, 5:05 AM

ashoat accepted this revision.Jan 5 2023, 8:28 AM

This revision is now accepted and ready to land.Jan 5 2023, 8:28 AM

Add lib dependency.

Harbormaster completed remote builds in B15155: Diff 20666.Jan 9 2023, 3:29 AM

Closed by commit rCOMM21395b9f8ad8: [desktop] Type bridge object between desktop and web (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyJan 11 2023, 7:11 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM21395b9f8ad8: [desktop] Type bridge object between desktop and web.

Revision Contents
Changeset List

Path

Size

desktop/

package.json

1 line

src/

preload.js

4 lines

lib/

types/

electron-types.js

14 lines

web/

electron.js

17 lines

Diff 20796

View Options

desktop/package.json

View Options

desktop/src/preload.js

View Options

lib/types/electron-types.js

View Options

[desktop] Type bridge object between desktop and webClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 20796

desktop/package.json

desktop/src/preload.js

lib/types/electron-types.js

web/electron.js

[desktop] Type bridge object between desktop and web
ClosedPublic
Actions

Revision Contents
Changeset List