Page MenuHomePhabricator

[native] Add fontSize option to Pill and ThreadPill components
ClosedPublic

Authored by inka on Jan 13 2023, 5:17 AM.
Tags
None
Referenced Files
F3493008: D6259.id20928.diff
Thu, Dec 19, 1:56 AM
F3492303: D6259.diff
Wed, Dec 18, 11:00 PM
Unknown Object (File)
Tue, Dec 3, 11:39 AM
Unknown Object (File)
Nov 13 2024, 7:23 AM
Unknown Object (File)
Nov 12 2024, 1:23 AM
Unknown Object (File)
Nov 8 2024, 10:04 AM
Unknown Object (File)
Nov 8 2024, 10:04 AM
Unknown Object (File)
Nov 8 2024, 10:04 AM
Subscribers

Details

Summary

Adding the possibility to change font size in Pill/ThreadPill components, because I'll need that in subchannels/sidebars modals, as discussed in
https://linear.app/comm/issue/ENG-2547/restyle-sidebarlistmodal-and-subchannelslistmodal

Test Plan

Run ios simulator, check that pills display correctly - ex in chat settings. Check that passing a fontSize prop changes the fon size.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 13 2023, 5:19 AM
Harbormaster failed remote builds in B15348: Diff 20928!

I thought of just allowing to pass a whole style, but I think it's good if we don't encourage diverging from the used style too much. Just like we didn't allow to pass any boarder radius values, just a boolean whether left and right corners should be rounded. So I just added what I needed.

inka requested review of this revision.Jan 16 2023, 1:08 AM
This revision is now accepted and ready to land.Jan 16 2023, 11:52 PM
This revision now requires review to proceed.Jan 17 2023, 4:41 AM
This revision is now accepted and ready to land.Jan 18 2023, 2:08 AM